linux-kernel - Re: [PATCH] cxl/uapi: Add warning on CXL command enum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 8 Dec 2022 10:41:45 +0000
From:   Jonathan Cameron <Jonathan.Cameron@...wei.com>
To:     Dave Jiang <dave.jiang@...el.com>
CC:     <ira.weiny@...el.com>, Dan Williams <dan.j.williams@...el.com>,
        "Alison Schofield" <alison.schofield@...el.com>,
        Vishal Verma <vishal.l.verma@...el.com>,
        <linux-cxl@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cxl/uapi: Add warning on CXL command enum

On Wed, 7 Dec 2022 17:27:18 -0700
Dave Jiang <dave.jiang@...el.com> wrote:

> On 12/7/2022 5:01 PM, ira.weiny@...el.com wrote:
> > From: Ira Weiny <ira.weiny@...el.com>
> > 
> > The CXL command enum is exported to user space and must maintain
> > backwards compatibility.
> > 
> > Add comment that new defines must be added to the end of the list.
> > 
> > Suggested-by: Dan Williams <dan.j.williams@...el.com>
> > Signed-off-by: Ira Weiny <ira.weiny@...el.com>  
> 
> Reviewed-by: Dave Jiang <dave.jiang@...el.com>
Good to have.

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>

> 
> > ---
> >   include/uapi/linux/cxl_mem.h | 4 ++++
> >   1 file changed, 4 insertions(+)
> > 
> > diff --git a/include/uapi/linux/cxl_mem.h b/include/uapi/linux/cxl_mem.h
> > index c71021a2a9ed..459a3f7f764b 100644
> > --- a/include/uapi/linux/cxl_mem.h
> > +++ b/include/uapi/linux/cxl_mem.h
> > @@ -19,6 +19,10 @@
> >   #define CXL_MEM_QUERY_COMMANDS _IOR(0xCE, 1, struct cxl_mem_query_commands)
> >   #define CXL_MEM_SEND_COMMAND _IOWR(0xCE, 2, struct cxl_send_command)
> >   
> > +/*
> > + * NOTE: New defines must be added to the end of the list to preserve
> > + * compatibility because this enum is exported to user space.
> > + */
> >   #define CXL_CMDS                                                          \
> >   	___C(INVALID, "Invalid Command"),                                 \
> >   	___C(IDENTIFY, "Identify Command"),                               \
> > 
> > base-commit: acb704099642bc822ef2aed223a0b8db1f7ea76e