linux-kernel - Re: [PATCH linux-next] MIPS: OCTEON: cvmx-bootmem: use strscpy() to instead of? strncpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221208103618.GA8388@alpha.franken.de>
Date:   Thu, 8 Dec 2022 11:36:18 +0100
From:   Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To:     yang.yang29@....com.cn
Cc:     julia.lawall@...ia.fr, linux-mips@...r.kernel.org,
        linux-kernel@...r.kernel.org, xu.panda@....com.cn
Subject: Re: [PATCH linux-next] MIPS: OCTEON: cvmx-bootmem: use strscpy() to
 instead of? strncpy()

On Sat, Dec 03, 2022 at 02:17:16PM +0800, yang.yang29@....com.cn wrote:
> From: Xu Panda <xu.panda@....com.cn>
> 
> The implementation of strscpy() is more robust and safer.
> 
> Signed-off-by: Xu Panda <xu.panda@....com.cn>
> Signed-off-by: Yang Yang <yang.yang29@....com>
> ---
>  arch/mips/cavium-octeon/executive/cvmx-bootmem.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/mips/cavium-octeon/executive/cvmx-bootmem.c b/arch/mips/cavium-octeon/executive/cvmx-bootmem.c
> index 306cee07ce3f..334bf8e577e5 100644
> --- a/arch/mips/cavium-octeon/executive/cvmx-bootmem.c
> +++ b/arch/mips/cavium-octeon/executive/cvmx-bootmem.c
> @@ -780,9 +780,8 @@ int64_t cvmx_bootmem_phy_named_block_alloc(uint64_t size, uint64_t min_addr,
>  	if (addr_allocated >= 0) {
>  		named_block_desc_ptr->base_addr = addr_allocated;
>  		named_block_desc_ptr->size = size;
> -		strncpy(named_block_desc_ptr->name, name,
> +		strscpy(named_block_desc_ptr->name, name,
>  			cvmx_bootmem_desc->named_block_name_len);
> -		named_block_desc_ptr->name[cvmx_bootmem_desc->named_block_name_len - 1] = 0;
>  	}
> 
>  	if (!(flags & CVMX_BOOTMEM_FLAG_NO_LOCKING))
> -- 
> 2.15.2

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]