linux-kernel - Re: [PATCH] crypto: atmel: Add capability case for the 0x600 SHA and AES IP versions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 8 Dec 2022 11:56:47 +0100
From:   Nicolas Ferre <nicolas.ferre@...rochip.com>
To:     Sergiu Moga <sergiu.moga@...rochip.com>,
        <herbert@...dor.apana.org.au>, <davem@...emloft.net>,
        <alexandre.belloni@...tlin.com>, <claudiu.beznea@...rochip.com>
CC:     <linux-crypto@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] crypto: atmel: Add capability case for the 0x600 SHA and
 AES IP versions

On 07/12/2022 at 14:59, Sergiu Moga wrote:
> In order for the driver to be made aware of the capabilities of the SHA
> and AES IP versions 0x600 , such as those present on the SAM9X60 SoC's,
> add a corresponding switch case to the capability method of the respective
> drivers. Without this, besides the capabilities not being correctly set,
> the self tests may hang since the driver is endlessly waiting for a
> completion to be set by a never occurring DMA interrupt handler.
> 
> Signed-off-by: Sergiu Moga <sergiu.moga@...rochip.com>

Acked-by: Nicolas Ferre <nicolas.ferre@...rochip.com>

Thanks Sergiu, best regards,
   Nicolas

> ---
>   drivers/crypto/atmel-aes.c | 1 +
>   drivers/crypto/atmel-sha.c | 1 +
>   2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/crypto/atmel-aes.c b/drivers/crypto/atmel-aes.c
> index 886bf258544c..063394cfa874 100644
> --- a/drivers/crypto/atmel-aes.c
> +++ b/drivers/crypto/atmel-aes.c
> @@ -2510,6 +2510,7 @@ static void atmel_aes_get_cap(struct atmel_aes_dev *dd)
>   	/* keep only major version number */
>   	switch (dd->hw_version & 0xff0) {
>   	case 0x700:
> +	case 0x600:
>   	case 0x500:
>   		dd->caps.has_dualbuff = 1;
>   		dd->caps.has_cfb64 = 1;
> diff --git a/drivers/crypto/atmel-sha.c b/drivers/crypto/atmel-sha.c
> index ca4b01926d1b..00be792e605c 100644
> --- a/drivers/crypto/atmel-sha.c
> +++ b/drivers/crypto/atmel-sha.c
> @@ -2509,6 +2509,7 @@ static void atmel_sha_get_cap(struct atmel_sha_dev *dd)
>   	/* keep only major version number */
>   	switch (dd->hw_version & 0xff0) {
>   	case 0x700:
> +	case 0x600:
>   	case 0x510:
>   		dd->caps.has_dma = 1;
>   		dd->caps.has_dualbuff = 1;

-- 
Nicolas Ferre