linux-kernel - Re: [PATCH v3 3/6] drm/vc4: use new debugfs device-centered functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221208121131.cm2f6e33el5agf5p@houat>
Date:   Thu, 8 Dec 2022 13:11:31 +0100
From:   Maxime Ripard <maxime@...no.tech>
To:     Maíra Canal <mcanal@...lia.com>
Cc:     Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Oded Gabbay <ogabbay@...nel.org>,
        Jani Nikula <jani.nikula@...ux.intel.com>,
        Melissa Wen <mwen@...lia.com>,
        André Almeida <andrealmeid@...lia.com>,
        Emma Anholt <emma@...olt.net>,
        Rodrigo Siqueira <rodrigosiqueiramelo@...il.com>,
        Wambui Karuga <wambui@...uga.org>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/6] drm/vc4: use new debugfs device-centered functions

On Wed, Dec 07, 2022 at 10:23:22AM -0300, Maíra Canal wrote:
> Currently, vc4 has its own debugfs infrastructure that adds the debugfs
> files on drm_dev_register(). With the introduction of the new debugfs,
> functions, replace the vc4 debugfs structure with the DRM debugfs
> device-centered function, drm_debugfs_add_file().
> 
> Moreover, remove the explicit error handling of debugfs related functions,
> considering that the only failure mode is -ENOMEM and also that error
> handling is not recommended for debugfs functions, as pointed out in [1].
> 
> [1] https://lore.kernel.org/all/YWAmZdRwnAt6wh9B@kroah.com/
> 
> Signed-off-by: Maíra Canal <mcanal@...lia.com>

Reviewed-by: Maxime Ripard <maxime@...no.tech>

Maxime

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)