linux-kernel - Re: [PATCH net-next v4 1/2] macsec: add support for IFLA_MACSEC_OFFLOAD in macsec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y5HZVhvkdCyJOgS6@nanopsycho>
Date:   Thu, 8 Dec 2022 13:32:22 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     ehakim@...dia.com
Cc:     linux-kernel@...r.kernel.org, raeds@...dia.com,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, netdev@...r.kernel.org, sd@...asysnail.net,
        atenart@...nel.org
Subject: Re: [PATCH net-next v4 1/2] macsec: add support for
 IFLA_MACSEC_OFFLOAD in macsec_changelink

Thu, Dec 08, 2022 at 12:55:16PM CET, ehakim@...dia.com wrote:
>From: Emeel Hakim <ehakim@...dia.com>
>
>Add support for changing Macsec offload selection through the
>netlink layer by implementing the relevant changes in
>macsec_changelink.
>
>Since the handling in macsec_changelink is similar to macsec_upd_offload,
>update macsec_upd_offload to use a common helper function to avoid
>duplication.
>
>Example for setting offload for a macsec device:
>    ip link set macsec0 type macsec offload mac
>
>Reviewed-by: Raed Salem <raeds@...dia.com>
>Signed-off-by: Emeel Hakim <ehakim@...dia.com>

Looks fine to me.
Reviewed-by: Jiri Pirko <jiri@...dia.com>