linux-kernel - Re: [PATCH v2 1/3] staging: vme_user: add the spaces around the "*"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y5HkBnptiY06DtRL@kroah.com>
Date:   Thu, 8 Dec 2022 14:17:58 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Matt Jan <zoo868e@...il.com>
Cc:     Martyn Welch <martyn@...chs.me.uk>,
        Manohar Vanga <manohar.vanga@...il.com>,
        linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH v2 1/3] staging: vme_user: add the spaces around the "*"

On Thu, Dec 08, 2022 at 06:38:13PM +0800, Matt Jan wrote:
> Add a space around the "*" at vme_bridge.h to clear up a checkpatch
> check.
> 
> Signed-off-by: Matt Jan <zoo868e@...il.com>
> ---
>  drivers/staging/vme_user/vme_bridge.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/vme_user/vme_bridge.h b/drivers/staging/vme_user/vme_bridge.h
> index 0bbefe9851d7..e17a8f7de165 100644
> --- a/drivers/staging/vme_user/vme_bridge.h
> +++ b/drivers/staging/vme_user/vme_bridge.h
> @@ -4,7 +4,7 @@
>  
>  #include "vme.h"
>  
> -#define VME_CRCSR_BUF_SIZE (508*1024)
> +#define VME_CRCSR_BUF_SIZE (508 * 1024)
>  /*
>   * Resource structures
>   */
> -- 
> 2.25.1
> v2: Resend the correct patch set, noted by Greg Kroah-Hartmamn <gregkh@...uxfoundation.org>

This "v2" stuff goes below the "---" line, not down here below the patch
itself.

Also this series is not properly threaded at all, please use 'git
send-email' to do so so that our tools will properly pick up the whole
thread, and not just individual emails.

Can you fix this all up and send a v3 please?

thanks,

greg k-h