linux-kernel - Re: [PATCH] platform/x86: mxm-wmi: fix memleak in mxm_wmi_call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87f62d40-9b2d-8a99-0758-cf2a482ef56d@redhat.com>
Date:   Thu, 8 Dec 2022 16:32:45 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Yu Liao <liaoyu15@...wei.com>, markgross@...nel.org
Cc:     airlied@...hat.com, mjg@...hat.com,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
        liwei391@...wei.com
Subject: Re: [PATCH] platform/x86: mxm-wmi: fix memleak in
 mxm_wmi_call_mx[ds|mx]()

Hi,

On 11/29/22 02:11, Yu Liao wrote:
> The ACPI buffer memory (out.pointer) returned by wmi_evaluate_method()
> is not freed after the call, so it leads to memory leak.
> 
> The method results in ACPI buffer is not used, so just pass NULL to
> wmi_evaluate_method() which fixes the memory leak.
> 
> Fixes: 99b38b4acc0d ("platform/x86: add MXM WMI driver.")
> Signed-off-by: Yu Liao <liaoyu15@...wei.com>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans



> ---
>  drivers/platform/x86/mxm-wmi.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/platform/x86/mxm-wmi.c b/drivers/platform/x86/mxm-wmi.c
> index 9a19fbd2f734..9a457956025a 100644
> --- a/drivers/platform/x86/mxm-wmi.c
> +++ b/drivers/platform/x86/mxm-wmi.c
> @@ -35,13 +35,11 @@ int mxm_wmi_call_mxds(int adapter)
>  		.xarg = 1,
>  	};
>  	struct acpi_buffer input = { (acpi_size)sizeof(args), &args };
> -	struct acpi_buffer output = { ACPI_ALLOCATE_BUFFER, NULL };
>  	acpi_status status;
>  
>  	printk("calling mux switch %d\n", adapter);
>  
> -	status = wmi_evaluate_method(MXM_WMMX_GUID, 0x0, adapter, &input,
> -				     &output);
> +	status = wmi_evaluate_method(MXM_WMMX_GUID, 0x0, adapter, &input, NULL);
>  
>  	if (ACPI_FAILURE(status))
>  		return status;
> @@ -60,13 +58,11 @@ int mxm_wmi_call_mxmx(int adapter)
>  		.xarg = 1,
>  	};
>  	struct acpi_buffer input = { (acpi_size)sizeof(args), &args };
> -	struct acpi_buffer output = { ACPI_ALLOCATE_BUFFER, NULL };
>  	acpi_status status;
>  
>  	printk("calling mux switch %d\n", adapter);
>  
> -	status = wmi_evaluate_method(MXM_WMMX_GUID, 0x0, adapter, &input,
> -				     &output);
> +	status = wmi_evaluate_method(MXM_WMMX_GUID, 0x0, adapter, &input, NULL);
>  
>  	if (ACPI_FAILURE(status))
>  		return status;