linux-kernel - [PATCH] PCI: mt7621: Sleep a bit after power on the PCIs phy ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Fri,  9 Dec 2022 08:17:03 +0100
From:   Sergio Paracuellos <sergio.paracuellos@...il.com>
To:     linux-pci@...r.kernel.org
Cc:     bhelgaas@...gle.com, lpieralisi@...nel.org, robh@...nel.org,
        kw@...ux.com, matthias.bgg@...il.com, linux-kernel@...r.kernel.org
Subject: [PATCH] PCI: mt7621: Sleep a bit after power on the PCIs phy ports

Some devices like ZBT WE1326 and ZBT WF3526-P need to sleep a bit after call
to mt7621_pcie_init_port() driver function to get into reliable boots for
both warn and hard resets. The needed time for these devices to always detect
the ports seems to be from 75 to 100 milliseconds. Hence, properly add an
extra 100 milliseconds msleep() call to make also these devices work.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@...il.com>
---
Hi Bjorn / Lorenzo,

I send previous patch here [0] related with this issue. Since after a bit
of testing with these devices by openwrt community [1] we end up that there is
no need of increasing PERST_DELAY_MS definition. This is also the reason
of not sending a v2 for this but a new patch with the proper solution.
I preferred to just use the same PERST_DELAY_MS define also for this to
not perform extra changes but the needed to the driver. If you prefer
me to write new definitions for all the sleep paths you pointed out in
[0], just let me know and I will send them also.

Thanks in advance for your time.

Best regards,
    Sergio Paracuellos

[0]: https://lore.kernel.org/linux-pci/20221119110837.2419466-1-sergio.paracuellos@gmail.com/T/#u
[1]: https://github.com/openwrt/openwrt/pull/11220

 drivers/pci/controller/pcie-mt7621.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pci/controller/pcie-mt7621.c b/drivers/pci/controller/pcie-mt7621.c
index 4bd1abf26008..3311ca64b315 100644
--- a/drivers/pci/controller/pcie-mt7621.c
+++ b/drivers/pci/controller/pcie-mt7621.c
@@ -369,6 +369,7 @@ static int mt7621_pcie_init_ports(struct mt7621_pcie *pcie)
 		}
 	}

+	msleep(PERST_DELAY_MS);
 	mt7621_pcie_reset_ep_deassert(pcie);

 	tmp = NULL;
-- 
2.25.1