linux-kernel - RE: [PATCH] iio: adc: vf610_adc: Convert to use sysfs_emit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 9 Dec 2022 08:28:02 +0000
From:   Bough Chen <haibo.chen@....com>
To:     "ye.xingchen@....com.cn" <ye.xingchen@....com.cn>,
        "jic23@...nel.org" <jic23@...nel.org>
CC:     "andriy.shevchenko@...ux.intel.com" 
        <andriy.shevchenko@...ux.intel.com>,
        "lars@...afoo.de" <lars@...afoo.de>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] iio: adc: vf610_adc: Convert to use sysfs_emit_at() API

> -----Original Message-----
> From: ye.xingchen@....com.cn <ye.xingchen@....com.cn>
> Sent: 2022年12月7日 15:35
> To: jic23@...nel.org
> Cc: Bough Chen <haibo.chen@....com>; andriy.shevchenko@...ux.intel.com;
> lars@...afoo.de; linux-iio@...r.kernel.org; dl-linux-imx <linux-imx@....com>;
> linux-kernel@...r.kernel.org
> Subject: [PATCH] iio: adc: vf610_adc: Convert to use sysfs_emit_at() API
> 
> From: ye xingchen <ye.xingchen@....com.cn>
> 
> Follow the advice of the Documentation/filesystems/sysfs.rst and show() should
> only use sysfs_emit() or sysfs_emit_at() when formatting the value to be
> returned to user space.
> 
> Signed-off-by: ye xingchen <ye.xingchen@....com.cn>

Acked-by: Haibo Chen <haibo.chen@....com>

Best Regards
Haibo Chen
> ---
>  drivers/iio/adc/vf610_adc.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/adc/vf610_adc.c b/drivers/iio/adc/vf610_adc.c index
> ae31aafd2653..dbf80f5f674b 100644
> --- a/drivers/iio/adc/vf610_adc.c
> +++ b/drivers/iio/adc/vf610_adc.c
> @@ -606,8 +606,7 @@ static ssize_t vf610_show_samp_freq_avail(struct
> device *dev,
>  	int i;
> 
>  	for (i = 0; i < ARRAY_SIZE(info->sample_freq_avail); i++)
> -		len += scnprintf(buf + len, PAGE_SIZE - len,
> -			"%u ", info->sample_freq_avail[i]);
> +		len += sysfs_emit_at(buf, len, "%u ", info->sample_freq_avail[i]);
> 
>  	/* replace trailing space by newline */
>  	buf[len - 1] = '\n';
> --
> 2.25.1