linux-kernel - Re: [PATCH v13 1/2] thermal: Add thermal driver for Sunplus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 9 Dec 2022 16:35:46 +0800
From:   kernel test robot <lkp@...el.com>
To:     Li-hao Kuo <lhjeff911@...il.com>, rafael@...nel.org,
        krzk@...nel.org, rui.zhang@...el.com, daniel.lezcano@...aro.org,
        amitk@...nel.org, robh+dt@...nel.org, linux-pm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        lh.kuo@...plus.com, Li-hao Kuo <lhjeff911@...il.com>
Subject: Re: [PATCH v13 1/2] thermal: Add thermal driver for Sunplus

Hi Li-hao,

I love your patch! Yet something to improve:

[auto build test ERROR on rafael-pm/thermal]
[also build test ERROR on krzk-dt/for-next linus/master v6.1-rc8 next-20221208]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Li-hao-Kuo/Add-thermal-control-driver-for-Sunplus-SoC/20221207-135102
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git thermal
patch link:    https://lore.kernel.org/r/076585e120b64832dcb81e39f3e59d719148816b.1665990345.git.lhjeff911%40gmail.com
patch subject: [PATCH v13 1/2] thermal: Add thermal driver for Sunplus
config: powerpc-allyesconfig
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 6e4cea55f0d1104408b26ac574566a0e4de48036)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install powerpc cross compiling tool for clang build
        # apt-get install binutils-powerpc-linux-gnu
        # https://github.com/intel-lab-lkp/linux/commit/0a55de700cd954776347017ffe2fbad2c7446ec9
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Li-hao-Kuo/Add-thermal-control-driver-for-Sunplus-SoC/20221207-135102
        git checkout 0a55de700cd954776347017ffe2fbad2c7446ec9
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash drivers/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> drivers/thermal/sunplus_thermal.c:75:14: error: incompatible function pointer types initializing 'int (*)(struct thermal_zone_device *, int *)' with an expression of type 'int (void *, int *)' [-Wincompatible-function-pointer-types]
           .get_temp = sp_thermal_get_sensor_temp,
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~
   1 error generated.


vim +75 drivers/thermal/sunplus_thermal.c

    73	
    74	static const struct thermal_zone_device_ops sp_of_thermal_ops = {
  > 75		.get_temp = sp_thermal_get_sensor_temp,
    76	};
    77	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (329417 bytes)