linux-kernel - Re: [PATCH] mmc: sdhci-sprd: Disable CLK_AUTO when the clock is less than 400K

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 9 Dec 2022 10:33:49 +0100
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Wenchao Chen <wenchao.chen@...soc.com>
Cc:     adrian.hunter@...el.com, orsonzhai@...il.com,
        baolin.wang@...ux.alibaba.com, zhang.lyra@...il.com,
        linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
        zhenxiong.lai@...soc.com, yuelin.tang@...soc.com
Subject: Re: [PATCH] mmc: sdhci-sprd: Disable CLK_AUTO when the clock is less
 than 400K

On Wed, 7 Dec 2022 at 06:20, Wenchao Chen <wenchao.chen@...soc.com> wrote:
>
> When the clock is less than 400K, some SD cards fail to initialize
> because CLK_AUTO is enabled.
>
> Fixes: fb8bd90f83c4 ("mmc: sdhci-sprd: Add Spreadtrum's initial host controller")
> Signed-off-by: Wenchao Chen <wenchao.chen@...soc.com>

Applied for next, and by adding a stable tag, thanks!

Kind regards
Uffe

> ---
>  drivers/mmc/host/sdhci-sprd.c | 16 +++++++++-------
>  1 file changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-sprd.c b/drivers/mmc/host/sdhci-sprd.c
> index bec3f9e3cd3f..525f979e2a97 100644
> --- a/drivers/mmc/host/sdhci-sprd.c
> +++ b/drivers/mmc/host/sdhci-sprd.c
> @@ -228,13 +228,15 @@ static inline void _sdhci_sprd_set_clock(struct sdhci_host *host,
>         div = ((div & 0x300) >> 2) | ((div & 0xFF) << 8);
>         sdhci_enable_clk(host, div);
>
> -       /* enable auto gate sdhc_enable_auto_gate */
> -       val = sdhci_readl(host, SDHCI_SPRD_REG_32_BUSY_POSI);
> -       mask = SDHCI_SPRD_BIT_OUTR_CLK_AUTO_EN |
> -              SDHCI_SPRD_BIT_INNR_CLK_AUTO_EN;
> -       if (mask != (val & mask)) {
> -               val |= mask;
> -               sdhci_writel(host, val, SDHCI_SPRD_REG_32_BUSY_POSI);
> +       /* Enable CLK_AUTO when the clock is greater than 400K. */
> +       if (clk > 400000) {
> +               val = sdhci_readl(host, SDHCI_SPRD_REG_32_BUSY_POSI);
> +               mask = SDHCI_SPRD_BIT_OUTR_CLK_AUTO_EN |
> +                       SDHCI_SPRD_BIT_INNR_CLK_AUTO_EN;
> +               if (mask != (val & mask)) {
> +                       val |= mask;
> +                       sdhci_writel(host, val, SDHCI_SPRD_REG_32_BUSY_POSI);
> +               }
>         }
>  }
>
> --
> 2.17.1
>