[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8c40646b-3422-c2f5-49c3-60a2beefbcff@starfivetech.com>
Date: Fri, 9 Dec 2022 19:31:07 +0800
From: William Qiu <william.qiu@...rfivetech.com>
To: Linus Walleij <linus.walleij@...aro.org>
CC: <linux-riscv@...ts.infradead.org>, <devicetree@...r.kernel.org>,
<linux-mmc@...r.kernel.org>, Rob Herring <robh+dt@...nel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@...aro.org>,
Jaehoon Chung <jh80.chung@...sung.com>,
Ulf Hansson <ulf.hansson@...aro.org>,
<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 3/3] riscv: dts: starfive: Add mmc node
On 2022/12/9 5:15, Linus Walleij wrote:
> Hi William,
>
> thanks for your patch!
>
> On Wed, Dec 7, 2022 at 2:17 PM William Qiu <william.qiu@...rfivetech.com> wrote:
>
>> + starfive,sys-syscon = <&sys_syscon 0x14 0x1a 0x7c000000>;
> (...)
>> + starfive,sys-syscon = <&sys_syscon 0x9c 0x1 0x3e>;
>
> These are registster offsets and shifts. Don't define such stuff in your device
> tree, use #defines in the code and just provide the phandle.
>
Hi Linus,
I will use #define in code instead in device tree.
Thank you for taking time to review and provide helpful comments for this patch.
Best Regards,
William Qiu
> Yours,
> Linus Walleij
Powered by blists - more mailing lists