linux-kernel - Re: [PATCH linux-next] backlight: use sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y5MvULWEnqp7pzft@aspen.lan>
Date:   Fri, 9 Dec 2022 12:51:28 +0000
From:   Daniel Thompson <daniel.thompson@...aro.org>
To:     ye.xingchen@....com.cn
Cc:     lee@...nel.org, jingoohan1@...il.com, deller@....de,
        dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH linux-next] backlight: use sysfs_emit() to instead of
 scnprintf()

On Mon, Dec 05, 2022 at 03:56:47PM +0800, ye.xingchen@....com.cn wrote:
> Subject: [PATCH linux-next] backlight: use sysfs_emit() to instead of
> scnprintf()

Isn't this a v2?

(this isn't just a "nice to have"... I ended up delaying review for
several days until I had time to look up where I had seen these changes
before)


> From: ye xingchen <ye.xingchen@....com.cn>
>
> Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> should only use sysfs_emit() or sysfs_emit_at() when formatting the
> value to be returned to user space.
>
> Signed-off-by: ye xingchen <ye.xingchen@....com.cn>

Reviewed-by: Daniel Thompson <daniel.thompson@...aro.org>


Daniel.