linux-kernel - Re: [PATCH] i2c: designware: Fix unbalanced suspended flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y5NAXP718ZS2CZUb@smile.fi.intel.com>
Date:   Fri, 9 Dec 2022 16:04:12 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Hans de Goede <hdegoede@...hat.com>
Cc:     Richard Fitzgerald <rf@...nsource.cirrus.com>, wsa@...nel.org,
        jarkko.nikula@...ux.intel.com, mika.westerberg@...ux.intel.com,
        jsd@...ihalf.com, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org, patches@...nsource.cirrus.com
Subject: Re: [PATCH] i2c: designware: Fix unbalanced suspended flag

On Fri, Dec 09, 2022 at 01:15:21PM +0100, Hans de Goede wrote:
> On 12/9/22 12:40, Richard Fitzgerald wrote:

...

> Did you add printk messages to the suspend/resume callbacks of
> i2c-designware-platdrv.c which show the system suspend callback
> being called but not the system resume one ?

Side note: It's better to use ftrace for that, less invasive time-wise.

...

> Did you add a printk to both the if + else paths
> and have you ever seen the controller not get
> resumed with this test added ?

-- 
With Best Regards,
Andy Shevchenko