linux-kernel - Re: [PATCH] Added ability to vmalloc executable memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202212092253.UgsxA2Gh-lkp@intel.com>
Date:   Fri, 9 Dec 2022 22:18:52 +0800
From:   kernel test robot <lkp@...el.com>
To:     Xander Moerkerken <xandermoerkerken@...il.com>,
        akpm@...ux-foundation.org
Cc:     oe-kbuild-all@...ts.linux.dev, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org,
        Xander Moerkerken <xander.moerkerken@...il.com>
Subject: Re: [PATCH] Added ability to vmalloc executable memory

Hi Xander,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on akpm-mm/mm-everything]
[also build test ERROR on linus/master v6.1-rc8 next-20221208]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Xander-Moerkerken/Added-ability-to-vmalloc-executable-memory/20221209-211212
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link:    https://lore.kernel.org/r/20221209131052.64235-1-xander.moerkerken%40omron.com
patch subject: [PATCH] Added ability to vmalloc executable memory
config: powerpc-allnoconfig
compiler: powerpc-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/86c4449bb255bd5320d7b260034db7845878bc12
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Xander-Moerkerken/Added-ability-to-vmalloc-executable-memory/20221209-211212
        git checkout 86c4449bb255bd5320d7b260034db7845878bc12
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All error/warnings (new ones prefixed by >>):

   mm/vmalloc.c: In function '__vmalloc_exec':
>> mm/vmalloc.c:3314:16: error: implicit declaration of function '__vmalloc_node_prot'; did you mean '__vmalloc_node'? [-Werror=implicit-function-declaration]
    3314 |         return __vmalloc_node_prot(size, 1, gfp_mask, PAGE_KERNEL_EXEC,
         |                ^~~~~~~~~~~~~~~~~~~
         |                __vmalloc_node
>> mm/vmalloc.c:3314:16: warning: returning 'int' from a function with return type 'void *' makes pointer from integer without a cast [-Wint-conversion]
    3314 |         return __vmalloc_node_prot(size, 1, gfp_mask, PAGE_KERNEL_EXEC,
         |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    3315 |                                   NUMA_NO_NODE, __builtin_return_address(0));
         |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +3314 mm/vmalloc.c

  3310	
  3311	
  3312	void *__vmalloc_exec(unsigned long size, gfp_t gfp_mask)
  3313	{
> 3314		return __vmalloc_node_prot(size, 1, gfp_mask, PAGE_KERNEL_EXEC,
  3315		                          NUMA_NO_NODE, __builtin_return_address(0));
  3316	}
  3317	EXPORT_SYMBOL(__vmalloc_exec);
  3318	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (30751 bytes)