linux-kernel - Re: [PATCH] arm64: dts: zynqmp: Add xlnx prefix to GEM compatible string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d097b9f5-a82d-f343-088d-d745d5d1ed32@amd.com>
Date:   Fri, 9 Dec 2022 16:23:29 +0100
From:   Michal Simek <michal.simek@....com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        <linux-kernel@...r.kernel.org>, <monstr@...str.eu>,
        <michal.simek@...inx.com>, <git@...inx.com>
CC:     Harini Katakam <harini.katakam@....com>,
        David Heidelberg <david@...t.cz>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Michael Grzeschik <m.grzeschik@...gutronix.de>,
        Michael Tretter <m.tretter@...gutronix.de>,
        Piyush Mehta <piyush.mehta@...inx.com>,
        Rob Herring <robh+dt@...nel.org>,
        Robert Hancock <robert.hancock@...ian.com>,
        Sean Anderson <sean.anderson@...o.com>,
        <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] arm64: dts: zynqmp: Add xlnx prefix to GEM compatible
 string



On 12/9/22 16:11, Krzysztof Kozlowski wrote:
> On 09/12/2022 14:56, Michal Simek wrote:
>> From: Harini Katakam <harini.katakam@....com>
>>
>> cdns,zynq/zynqmp/versal-gem was recently deprecated in Linux in
>> favour of xlnx prefix. Add this new compatible string and retain
>> the existing string for compatibility with uboot drivers.
>>
>> Signed-off-by: Harini Katakam <harini.katakam@....com>
>> Signed-off-by: Michal Simek <michal.simek@....com>
>> ---
>>
>>   arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 8 ++++----
>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
>> index 8553299f12eb..233127d94204 100644
>> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
>> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
>> @@ -507,7 +507,7 @@ nand0: nand-controller@...00000 {
>>   		};
>>   
>>   		gem0: ethernet@...b0000 {
>> -			compatible = "cdns,zynqmp-gem", "cdns,gem";
>> +			compatible = "xlnx,zynqmp-gem", "cdns,zynqmp-gem", "cdns,gem";
> 
> That's not what the bindings are saying. If this was the intention of
> AMD, you should have replied to my patch that you need prolonged
> backwards compatibility.

I have sent the patch to U-Boot to support new compatible string and CC you on 
that too.

I have no problem to do switch just to xlnx one but it is not fully accurate 
that cdns,versal-gem wasn't used. True is not in Linux but it was used in U-Boot.

If we can go straight to xlnx,zynqmp-gem, cdns,gem I will send v2 of this patch.

Thanks,
Michal