linux-kernel - Re: [PATCH v10 0/3] crypto: hisilicon - supports device isolation feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y5NU9vLyEjekoWfj@kroah.com>
Date:   Fri, 9 Dec 2022 16:32:06 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     "yekai (A)" <yekai13@...wei.com>
Cc:     herbert@...dor.apana.org.au, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org, wangzhou1@...ilicon.com,
        liulongfang@...wei.com
Subject: Re: [PATCH v10 0/3] crypto: hisilicon - supports device isolation
 feature

On Fri, Dec 09, 2022 at 02:15:07PM +0800, yekai (A) wrote:
> 
> 
> On 2022/11/25 16:49, yekai (A) wrote:
> >
> > On 2022/11/19 15:48, Kai Ye wrote:
> >> 1、Add the uacce hardware error isolation interface. Hardware error 
> >>    thresholds can be configured by sysfs node. User can get the hardware
> >>    isolated state by sysfs node.
> >> 2、Defining the isolation strategy for uacce device by uacce sysfs node. 
> >>    If the number of hardware errors exceeds the configured value, the 
> >>    uacce device will not be available in user space.
> >> 3、The ACC VF device use the PF device isolation strategy.
> >>    
> >> changes v1->v2:
> >> 	- deleted dev_to_uacce api.
> >> 	- add vfs node doc. 
> >> 	- move uacce->ref to driver.
> >> changes v2->v3:
> >> 	- deleted some redundant code.
> >> 	- use qm state instead of reference count.
> >> 	- add null pointer check.
> >> 	- isolate_strategy_read() instead of a copy.
> >> changes v3->v4:
> >> 	- modify a comment
> >> changes v4->v5:
> >> 	- use bool instead of atomic.
> >> 	- isolation frequency instead of isolation command.
> >> changes v5->v6:
> >> 	- add is_visible in uacce.
> >> 	- add the description of the isolation strategy file node.
> >> changes v6->v7
> >> 	- add an example for isolate_strategy in Documentation.
> >> changes v7->v8
> >> 	- update the correct date.
> >> changes v8->v9
> >>     - move isolation strategy from qm to uacce.
> >> changes v9->v10
> >> 	- Go back to the v8 version of the solution.
> >> 	- Modify some code according to suggestions.
> >>
> >> Kai Ye (3):
> >>   uacce: supports device isolation feature
> >>   Documentation: add the device isolation feature sysfs nodes for uacce
> >>   crypto: hisilicon/qm - define the device isolation strategy
> >>
> >>  Documentation/ABI/testing/sysfs-driver-uacce |  18 ++
> >>  drivers/crypto/hisilicon/qm.c                | 169 +++++++++++++++++--
> >>  drivers/misc/uacce/uacce.c                   |  50 ++++++
> >>  include/linux/hisi_acc_qm.h                  |  15 ++
> >>  include/linux/uacce.h                        |  12 ++
> >>  5 files changed, 249 insertions(+), 15 deletions(-)
> >>
> > Hi Grek
> >
> > Just a friendly ping.
> >
> > Thanks
> > Kai
> 
> Hi Greg KH
> 
> Could you help me to apply this patchset v10?

Sorry, it needs review from the crypto maintainers before I can take it.

Also, it looks to be too late for 6.2-rc1 at this point in time.

thanks,

greg k-h