linux-kernel - Re: [PATCH v3] MIPS: BCM63xx: Add check for NULL for clk in clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a36149ce-3e04-819b-5ddf-842e3a7c2aec@linaro.org>
Date:   Fri, 9 Dec 2022 17:39:44 +0100
From:   Philippe Mathieu-Daudé <philmd@...aro.org>
To:     Anastasia Belova <abelova@...ralinux.ru>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Cc:     Randy Dunlap <rdunlap@...radead.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Ralf Baechle <ralf@...ux-mips.org>,
        Maxime Bizon <mbizon@...ebox.fr>, linux-mips@...r.kernel.org,
        linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org
Subject: Re: [PATCH v3] MIPS: BCM63xx: Add check for NULL for clk in
 clk_enable

On 9/12/22 11:05, Anastasia Belova wrote:
> Check clk for NULL before calling clk_enable_unlocked where clk
> is dereferenced. There is such check in other implementations
> of clk_enable.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Fixes: e7300d04bd08 ("MIPS: BCM63xx: Add support for the Broadcom BCM63xx family of SOCs.")
> Signed-off-by: Anastasia Belova <abelova@...ralinux.ru>
> ---
> v2: Fix errors reported by kernel test robot <lkp@...el.com>.
> v3: Merge several patches into single one.
>   arch/mips/bcm63xx/clk.c | 2 ++
>   1 file changed, 2 insertions(+)

Reviewed-by: Philippe Mathieu-Daudé <philmd@...aro.org>