linux-kernel - Re: [PATCH v2 1/2] locktorture: Allow non-rtmutex lock types to be boosted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221209163445.jl4wdnbha47si7h7@offworld>
Date:   Fri, 9 Dec 2022 08:34:45 -0800
From:   Davidlohr Bueso <dave@...olabs.net>
To:     "Joel Fernandes (Google)" <joel@...lfernandes.org>
Cc:     linux-kernel@...r.kernel.org,
        Josh Triplett <josh@...htriplett.org>,
        "Paul E. McKenney" <paulmck@...nel.org>, rcu@...r.kernel.org,
        connoro@...gle.com
Subject: Re: [PATCH v2 1/2] locktorture: Allow non-rtmutex lock types to be
 boosted

On Fri, 09 Dec 2022, Joel Fernandes (Google) wrote:

>Currently RT boosting is only done for rtmutex_lock, however with proxy
>execution, we also have the mutex_lock participating in priorities. To
>exercise the testing better, add RT boosting to other lock testing types
>as well, using a new knob (rt_boost).
>
>Tested with boot parameters:
>locktorture.torture_type=mutex_lock
>locktorture.onoff_interval=1
>locktorture.nwriters_stress=8
>locktorture.stutter=0
>locktorture.rt_boost=1
>locktorture.rt_boost_factor=1
>locktorture.nlocks=3
>
>For the rtmutex test, rt_boost is always enabled even if disabling is
>requested.
>
>Signed-off-by: Joel Fernandes (Google) <joel@...lfernandes.org>
>---
> kernel/locking/locktorture.c | 99 ++++++++++++++++++++----------------
> 1 file changed, 56 insertions(+), 43 deletions(-)
>
>diff --git a/kernel/locking/locktorture.c b/kernel/locking/locktorture.c
>index bc3557677eed..8968fd65a90d 100644
>--- a/kernel/locking/locktorture.c
>+++ b/kernel/locking/locktorture.c
>@@ -46,6 +46,8 @@ torture_param(int, shutdown_secs, 0, "Shutdown time (j), <= zero to disable.");
> torture_param(int, stat_interval, 60,
>	     "Number of seconds between stats printk()s");
> torture_param(int, stutter, 5, "Number of jiffies to run/halt test, 0=disable");
>+torture_param(int, rt_boost, 2,
>+		"Do periodic rt-boost. 0=Disable, 1=Only for rt_mutex, 2=For all lock types.");

Sorry if this was already discussed, but what would be the intent of option 2 without PE?

Thanks,
Davidlohr