[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <MWHPR11MB169375D09616C6EC3119B972EF1C9@MWHPR11MB1693.namprd11.prod.outlook.com>
Date: Fri, 9 Dec 2022 19:25:15 +0000
From: <Jerry.Ray@...rochip.com>
To: <olteanv@...il.com>
CC: <andrew@...n.ch>, <f.fainelli@...il.com>, <davem@...emloft.net>,
<edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<linux@...linux.org.uk>
Subject: RE: [PATCH net-next v4 1/2] dsa: lan9303: Whitespace Only
> Please name the commit message something more specific than "Whitespace Only",
> that is likely to not be confused with some other patch. A "Whitespace Only"
> patch can take place anywhere in this file. Like "align dsa_switch_ops members".
>
> Do you use a text editor which highlights tabs? The members above this
> line are aligned with tabs, the ones below with spaces. Still not
> exactly what I'd call "consistent".
>
Hi Vladimir,
Thank you for your comments. I will rename the patch to be more explicit and
will address the tabs-spaces issue you pointed out.
I'll look for a better Linux-based text editor this weekend. Do you have a
recommendation?
Regards,
Jerry.
Powered by blists - more mailing lists