| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202212100546.tYAzcCAa-lkp@intel.com>
Date: Sat, 10 Dec 2022 05:23:19 +0800
From: kernel test robot <lkp@...el.com>
To: "Matthew Wilcox (Oracle)" <willy@...radead.org>,
Ingo Molnar <mingo@...hat.com>,
Peter Zijlstra <peterz@...radead.org>,
Juri Lelli <juri.lelli@...hat.com>,
Vincent Guittot <vincent.guittot@...aro.org>,
Dietmar Eggemann <dietmar.eggemann@....com>,
Steven Rostedt <rostedt@...dmis.org>,
Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>,
Daniel Bristot de Oliveira <bristot@...hat.com>,
Valentin Schneider <vschneid@...hat.com>,
linux-kernel@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev,
"Matthew Wilcox (Oracle)" <willy@...radead.org>
Subject: Re: [PATCH] sched: Make const-safe
Hi Matthew,
I love your patch! Perhaps something to improve:
[auto build test WARNING on tip/sched/core]
[also build test WARNING on tip/master tip/auto-latest linus/master v6.1-rc8 next-20221208]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Matthew-Wilcox-Oracle/sched-Make-const-safe/20221210-000625
patch link: https://lore.kernel.org/r/20221209160431.1948817-1-willy%40infradead.org
patch subject: [PATCH] sched: Make const-safe
config: s390-randconfig-r044-20221209
compiler: s390-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/de0d96906898ccc52f76c2794ccdfbbcf94c9fe0
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Matthew-Wilcox-Oracle/sched-Make-const-safe/20221210-000625
git checkout de0d96906898ccc52f76c2794ccdfbbcf94c9fe0
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
kernel/sched/fair.c:5925:6: warning: no previous prototype for 'init_cfs_bandwidth' [-Wmissing-prototypes]
5925 | void init_cfs_bandwidth(struct cfs_bandwidth *cfs_b) {}
| ^~~~~~~~~~~~~~~~~~
kernel/sched/fair.c: In function 'se_fi_update':
>> kernel/sched/fair.c:11723:51: warning: passing argument 1 of 'cfs_rq_of' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
11723 | struct cfs_rq *cfs_rq = cfs_rq_of(se);
| ^~
In file included from kernel/sched/fair.c:55:
kernel/sched/sched.h:1442:61: note: expected 'struct sched_entity *' but argument is of type 'const struct sched_entity *'
1442 | static inline struct cfs_rq *cfs_rq_of(struct sched_entity *se)
| ~~~~~~~~~~~~~~~~~~~~~^~
kernel/sched/fair.c: At top level:
kernel/sched/fair.c:11735:6: warning: no previous prototype for 'task_vruntime_update' [-Wmissing-prototypes]
11735 | void task_vruntime_update(struct rq *rq, struct task_struct *p, bool in_fi)
| ^~~~~~~~~~~~~~~~~~~~
kernel/sched/fair.c:12345:6: warning: no previous prototype for 'free_fair_sched_group' [-Wmissing-prototypes]
12345 | void free_fair_sched_group(struct task_group *tg) { }
| ^~~~~~~~~~~~~~~~~~~~~
kernel/sched/fair.c:12347:5: warning: no previous prototype for 'alloc_fair_sched_group' [-Wmissing-prototypes]
12347 | int alloc_fair_sched_group(struct task_group *tg, struct task_group *parent)
| ^~~~~~~~~~~~~~~~~~~~~~
kernel/sched/fair.c:12352:6: warning: no previous prototype for 'online_fair_sched_group' [-Wmissing-prototypes]
12352 | void online_fair_sched_group(struct task_group *tg) { }
| ^~~~~~~~~~~~~~~~~~~~~~~
kernel/sched/fair.c:12354:6: warning: no previous prototype for 'unregister_fair_sched_group' [-Wmissing-prototypes]
12354 | void unregister_fair_sched_group(struct task_group *tg) { }
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +11723 kernel/sched/fair.c
c6047c2e3af68d Joel Fernandes (Google 2020-11-17 11715)
c6047c2e3af68d Joel Fernandes (Google 2020-11-17 11716) /*
c6047c2e3af68d Joel Fernandes (Google 2020-11-17 11717) * se_fi_update - Update the cfs_rq->min_vruntime_fi in a CFS hierarchy if needed.
c6047c2e3af68d Joel Fernandes (Google 2020-11-17 11718) */
de0d96906898cc Matthew Wilcox (Oracle 2022-12-09 11719) static void se_fi_update(const struct sched_entity *se, unsigned int fi_seq,
de0d96906898cc Matthew Wilcox (Oracle 2022-12-09 11720) bool forceidle)
c6047c2e3af68d Joel Fernandes (Google 2020-11-17 11721) {
c6047c2e3af68d Joel Fernandes (Google 2020-11-17 11722) for_each_sched_entity(se) {
c6047c2e3af68d Joel Fernandes (Google 2020-11-17 @11723) struct cfs_rq *cfs_rq = cfs_rq_of(se);
c6047c2e3af68d Joel Fernandes (Google 2020-11-17 11724)
c6047c2e3af68d Joel Fernandes (Google 2020-11-17 11725) if (forceidle) {
c6047c2e3af68d Joel Fernandes (Google 2020-11-17 11726) if (cfs_rq->forceidle_seq == fi_seq)
c6047c2e3af68d Joel Fernandes (Google 2020-11-17 11727) break;
c6047c2e3af68d Joel Fernandes (Google 2020-11-17 11728) cfs_rq->forceidle_seq = fi_seq;
c6047c2e3af68d Joel Fernandes (Google 2020-11-17 11729) }
c6047c2e3af68d Joel Fernandes (Google 2020-11-17 11730)
c6047c2e3af68d Joel Fernandes (Google 2020-11-17 11731) cfs_rq->min_vruntime_fi = cfs_rq->min_vruntime;
c6047c2e3af68d Joel Fernandes (Google 2020-11-17 11732) }
c6047c2e3af68d Joel Fernandes (Google 2020-11-17 11733) }
c6047c2e3af68d Joel Fernandes (Google 2020-11-17 11734)
--
0-DAY CI Kernel Test Service
https://01.org/lkp
View attachment "config" of type "text/plain" (71395 bytes)
Powered by blists - more mailing lists