lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20221210091242.GD21743@1wt.eu> Date: Sat, 10 Dec 2022 10:12:42 +0100 From: Willy Tarreau <w@....eu> To: "Paul E. McKenney" <paulmck@...nel.org> Cc: Sven Schnelle <svens@...ux.ibm.com>, Josh Triplett <josh@...htriplett.org>, Steven Rostedt <rostedt@...dmis.org>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>, Lai Jiangshan <jiangshanlai@...il.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH 0/5] add s390 support to nolibc and rcutorture On Fri, Dec 09, 2022 at 05:26:43PM -0800, Paul E. McKenney wrote: > On Fri, Dec 09, 2022 at 04:28:35PM +0100, Willy Tarreau wrote: > > On Fri, Dec 09, 2022 at 07:03:25AM -0800, Paul E. McKenney wrote: > > > On Fri, Dec 09, 2022 at 03:19:34PM +0100, Sven Schnelle wrote: > > > > Hi, > > > > > > > > these patches add support for the s390 architecture both to nolibc > > > > and rcutorture. Note that this only adds support for the 64 bit > > > > version, no support for 31 bit (compat) is added. For nolibc it > > > > includes one bugfix to make the fd_set datatype match the kernel > > > > type. > > > > > > Nice!!! > > > > indeed :-) > > > > > The rcutorture patches look plausible to me, but I must defer to Willy > > > Tarreau on the nolibc changes. > > > > I had a very quick glance over them and nothing shocked me. I just want > > to double-check the u32->long conversion with a careful eye but I'm happy > > to see that your rcutorture binary continues its diet on more and more > > architectures ;-) > > Very good, and I will await your review. So overall the series looks good to me except one occurrence of "s390x" instead of "s390" in arch.h which will prevent the build from working with the old "-include nolibc.h" mode. If Sven agrees we can fix it directly in the patch (drop the 'x' in the "#include") so that he does not need to respin the series. I'm deferring to you the final word on the part on rcutorture (but it looks trivially correct to me). Thanks! Willy
Powered by blists - more mailing lists