linux-kernel - Re: [PATCH -next V10 04/10] riscv: entry: Convert to generic entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <871qp7tfac.fsf@all.your.base.are.belong.to.us>
Date:   Sat, 10 Dec 2022 17:05:47 +0100
From:   Björn Töpel <bjorn@...nel.org>
To:     Guo Ren <guoren@...nel.org>
Cc:     arnd@...db.de, palmer@...osinc.com, tglx@...utronix.de,
        peterz@...radead.org, luto@...nel.org, conor.dooley@...rochip.com,
        heiko@...ech.de, jszhang@...nel.org, lazyparser@...il.com,
        falcon@...ylab.org, chenhuacai@...nel.org, apatel@...tanamicro.com,
        atishp@...shpatra.org, palmer@...belt.com,
        paul.walmsley@...ive.com, mark.rutland@....com,
        zouyipeng@...wei.com, bigeasy@...utronix.de,
        David.Laight@...lab.com, chenzhongjin@...wei.com,
        greentime.hu@...ive.com, andy.chiu@...ive.com, ben@...adent.org.uk,
        linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-riscv@...ts.infradead.org, Guo Ren <guoren@...ux.alibaba.com>
Subject: Re: [PATCH -next V10 04/10] riscv: entry: Convert to generic entry

Guo Ren <guoren@...nel.org> writes:

>> >  - Little modification on ret_from_fork & ret_from_kernel_thread
>>
>> What changes?
>  ENTRY(ret_from_fork)
> +       call schedule_tail
> +       move a0, sp /* pt_regs */
>         la ra, ret_from_exception
> -       tail schedule_tail
> +       tail syscall_exit_to_user_mode
>  ENDPROC(ret_from_fork)
>
>  ENTRY(ret_from_kernel_thread)
>         call schedule_tail
>         /* Call fn(arg) */
> -       la ra, ret_from_exception
>         move a0, s1
> -       jr s0
> +       jalr s0
> +       move a0, sp /* pt_regs */
> +       la ra, ret_from_exception
> +       tail syscall_exit_to_user_mode
>  ENDPROC(ret_from_kernel_thread)

Thanks for clearing that up! It's more useful to have a descriptive
text, than just "these functions were changed". (Why instead of what)


Cheers,
Björn