linux-kernel - Re: [PATCH] mount: rebuild error handling in do_new

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 10 Dec 2022 23:39:35 +0000
From:   Al Viro <viro@...iv.linux.org.uk>
To:     Chuang Wang <nashuiliang@...il.com>
Cc:     linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mount: rebuild error handling in do_new_mount

On Sun, Dec 04, 2022 at 11:00:05PM +0800, Chuang Wang wrote:
> When a function execution error is detected in do_new_mount, it should
> return immediately. Using this can make the code easier to understand.

Your piles of goto make it harder to follow and reason about.

NAKed-by: Al Viro <viro@...iv.linux.org.uk>