linux-kernel - Re: [PATCH v2] rtc: msc313: Fix function prototype mismatch in msc313_rtc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <167077884687.347026.2422549159298910618.b4-ty@bootlin.com>
Date:   Sun, 11 Dec 2022 18:14:41 +0100
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Kees Cook <keescook@...omium.org>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     linux-hardening@...r.kernel.org,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        kernel test robot <lkp@...el.com>,
        Romain Perier <romain.perier@...il.com>, llvm@...ts.linux.dev,
        Tom Rix <trix@...hat.com>,
        Nathan Chancellor <nathan@...nel.org>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Daniel Palmer <daniel@...ngy.jp>, linux-rtc@...r.kernel.org
Subject: Re: [PATCH v2] rtc: msc313: Fix function prototype mismatch in
 msc313_rtc_probe()

On Fri, 2 Dec 2022 10:45:30 -0800, Kees Cook wrote:
> With clang's kernel control flow integrity (kCFI, CONFIG_CFI_CLANG),
> indirect call targets are validated against the expected function
> pointer prototype to make sure the call target is valid to help mitigate
> ROP attacks. If they are not identical, there is a failure at run time,
> which manifests as either a kernel panic or thread getting killed.
> 
> msc313_rtc_probe() was passing clk_disable_unprepare() directly, which
> did not have matching prototypes for devm_add_action_or_reset()'s
> callback argument. Refactor to use devm_clk_get_enabled() instead.
> 
> [...]

Applied, thanks!

[1/1] rtc: msc313: Fix function prototype mismatch in msc313_rtc_probe()
      commit: 21b8a1dd56a163825e5749b303858fb902ebf198

Best regards,

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com