linux-kernel - Re: [PATCH] bus: qcom-ssc-block-bus: Fix resource release in .remove function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dd6bf955-05c7-e141-9ba6-b682163bd4a0@wanadoo.fr>
Date:   Sun, 11 Dec 2022 19:52:24 +0100
From:   Christophe JAILLET <christophe.jaillet@...adoo.fr>
To:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Philipp Zabel <p.zabel@...gutronix.de>
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH] bus: qcom-ssc-block-bus: Fix resource release in .remove
 function

Le 22/05/2022 à 14:31, Christophe JAILLET a écrit :
> These resources are allocated using devm_ioremap_resource(), so there is no
> need to call iounmap() explicitly.
> 
> Fixes: 97d485edc1d9 ("bus: add driver for initializing the SSC bus on (some) qcom SoCs")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>   drivers/bus/qcom-ssc-block-bus.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/bus/qcom-ssc-block-bus.c b/drivers/bus/qcom-ssc-block-bus.c
> index eedeb29a5ff3..eaa39e08dd96 100644
> --- a/drivers/bus/qcom-ssc-block-bus.c
> +++ b/drivers/bus/qcom-ssc-block-bus.c
> @@ -356,9 +356,6 @@ static int qcom_ssc_block_bus_remove(struct platform_device *pdev)
>   
>   	qcom_ssc_block_bus_deinit(&pdev->dev);
>   
> -	iounmap(data->reg_mpm_sscaon_config0);
> -	iounmap(data->reg_mpm_sscaon_config1);
> -
>   	qcom_ssc_block_bus_pds_disable(data->pds, data->num_pds);
>   	qcom_ssc_block_bus_pds_detach(&pdev->dev, data->pds, data->num_pds);
>   	pm_runtime_disable(&pdev->dev);

Hi,

polite reminder, with updated list from get_maintainer.pl

CJ