Date:   Mon, 12 Dec 2022 03:09:34 +0800
From:   kernel test robot <lkp@...el.com>
To:     Jiachen Zhang <zhangjiachen.jaycee@...edance.com>,
        Vivek Goyal <vgoyal@...hat.com>,
        Stefan Hajnoczi <stefanha@...hat.com>,
        Miklos Szeredi <miklos@...redi.hu>
Cc:     oe-kbuild-all@...ts.linux.dev,
        virtualization@...ts.linux-foundation.org,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jiachen Zhang <zhangjiachen.jaycee@...edance.com>,
        Connor Kuehl <ckuehl@...hat.com>
Subject: Re: [PATCH] virtiofs: enable multiple request queues

Hi Jiachen,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on mszeredi-fuse/for-next]
[also build test WARNING on linus/master v6.1-rc8 next-20221208]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Jiachen-Zhang/virtiofs-enable-multiple-request-queues/20221211-184228
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git for-next
patch link:    https://lore.kernel.org/r/20221211103857.25805-1-zhangjiachen.jaycee%40bytedance.com
patch subject: [PATCH] virtiofs: enable multiple request queues
config: loongarch-randconfig-s041-20221211
compiler: loongarch64-linux-gcc (GCC) 12.1.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-39-gce1a6720-dirty
        # https://github.com/intel-lab-lkp/linux/commit/691f021ab737166116f9fc6800904ebfed076f05
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Jiachen-Zhang/virtiofs-enable-multiple-request-queues/20221211-184228
        git checkout 691f021ab737166116f9fc6800904ebfed076f05
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=loongarch SHELL=/bin/bash fs/fuse/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

sparse warnings: (new ones prefixed by >>)
>> fs/fuse/virtio_fs.c:1266:16: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected void *ptr @@     got struct virtio_fs_vq *[noderef] __percpu *vq_proxy @@
   fs/fuse/virtio_fs.c:1266:16: sparse:     expected void *ptr
   fs/fuse/virtio_fs.c:1266:16: sparse:     got struct virtio_fs_vq *[noderef] __percpu *vq_proxy
>> fs/fuse/virtio_fs.c:1266:16: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected void *ptr @@     got struct virtio_fs_vq *[noderef] __percpu *vq_proxy @@
   fs/fuse/virtio_fs.c:1266:16: sparse:     expected void *ptr
   fs/fuse/virtio_fs.c:1266:16: sparse:     got struct virtio_fs_vq *[noderef] __percpu *vq_proxy
>> fs/fuse/virtio_fs.c:1266:16: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected void *ptr @@     got struct virtio_fs_vq *[noderef] __percpu *vq_proxy @@
   fs/fuse/virtio_fs.c:1266:16: sparse:     expected void *ptr
   fs/fuse/virtio_fs.c:1266:16: sparse:     got struct virtio_fs_vq *[noderef] __percpu *vq_proxy
>> fs/fuse/virtio_fs.c:1266:16: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected void *ptr @@     got struct virtio_fs_vq *[noderef] __percpu *vq_proxy @@
   fs/fuse/virtio_fs.c:1266:16: sparse:     expected void *ptr
   fs/fuse/virtio_fs.c:1266:16: sparse:     got struct virtio_fs_vq *[noderef] __percpu *vq_proxy

vim +1266 fs/fuse/virtio_fs.c

  1243	
  1244	static void virtio_fs_wake_pending_and_unlock(struct fuse_iqueue *fiq)
  1245	__releases(fiq->lock)
  1246	{
  1247		struct virtio_fs *fs;
  1248		struct fuse_req *req;
  1249		struct virtio_fs_vq *fsvq;
  1250		int ret;
  1251	
  1252		WARN_ON(list_empty(&fiq->pending));
  1253		req = list_last_entry(&fiq->pending, struct fuse_req, list);
  1254		clear_bit(FR_PENDING, &req->flags);
  1255		list_del_init(&req->list);
  1256		WARN_ON(!list_empty(&fiq->pending));
  1257		spin_unlock(&fiq->lock);
  1258	
  1259		fs = fiq->priv;
  1260	
  1261		pr_debug("%s: opcode %u unique %#llx nodeid %#llx in.len %u out.len %u\n",
  1262			  __func__, req->in.h.opcode, req->in.h.unique,
  1263			 req->in.h.nodeid, req->in.h.len,
  1264			 fuse_len_args(req->args->out_numargs, req->args->out_args));
  1265	
> 1266		fsvq = this_cpu_read(*fs->vq_proxy);
  1267	
  1268		ret = virtio_fs_enqueue_req(fsvq, req, false);
  1269		if (ret < 0) {
  1270			if (ret == -ENOMEM || ret == -ENOSPC) {
  1271				/*
  1272				 * Virtqueue full. Retry submission from worker
  1273				 * context as we might be holding fc->bg_lock.
  1274				 */
  1275				spin_lock(&fsvq->lock);
  1276				list_add_tail(&req->list, &fsvq->queued_reqs);
  1277				inc_in_flight_req(fsvq);
  1278				schedule_delayed_work(&fsvq->dispatch_work,
  1279							msecs_to_jiffies(1));
  1280				spin_unlock(&fsvq->lock);
  1281				return;
  1282			}
  1283			req->out.h.error = ret;
  1284			pr_err("virtio-fs: virtio_fs_enqueue_req() failed %d\n", ret);
  1285	
  1286			/* Can't end request in submission context. Use a worker */
  1287			spin_lock(&fsvq->lock);
  1288			list_add_tail(&req->list, &fsvq->end_reqs);
  1289			schedule_delayed_work(&fsvq->dispatch_work, 0);
  1290			spin_unlock(&fsvq->lock);
  1291			return;
  1292		}
  1293	}
  1294	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (163427 bytes)

Powered by blists - more mailing lists