lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 11 Dec 2022 21:14:09 +0100 From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> To: Konrad Dybcio <konrad.dybcio@...aro.org>, Andy Gross <agross@...nel.org>, Bjorn Andersson <andersson@...nel.org>, Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org> Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/4] arm64: dts: qcom: sc7180: move QUP and QSPI opp tables out of SoC node On 10/12/2022 13:29, Konrad Dybcio wrote: > > > On 10.12.2022 12:57, Krzysztof Kozlowski wrote: >> The SoC node is a simple-bus and its schema expect to have nodes only >> with unit addresses: >> >> sc7180-trogdor-lazor-r3.dtb: soc@0: opp-table-qspi: {'compatible': ['operating-points-v2'], 'phandle': [[186]], 'opp-75000000': >> ... 'required-opps': [[47]]}} should not be valid under {'type': 'object'} >> >> Move to top-level OPP tables: >> - QUP which is shared between multiple nodes, >> - QSPI which cannot be placed in its node due to address/size cells. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> >> --- >> arch/arm64/boot/dts/qcom/sc7180.dtsi | 76 ++++++++++++++-------------- >> 1 file changed, 38 insertions(+), 38 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi >> index ea886cf08b4d..735581097295 100644 >> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi >> @@ -538,6 +538,44 @@ cpu6_opp16: opp-2553600000 { >> }; >> }; >> >> + qspi_opp_table: opp-table-qspi { >> + compatible = "operating-points-v2"; >> + >> + opp-75000000 { >> + opp-hz = /bits/ 64 <75000000>; >> + required-opps = <&rpmhpd_opp_low_svs>; >> + }; >> + >> + opp-150000000 { >> + opp-hz = /bits/ 64 <150000000>; >> + required-opps = <&rpmhpd_opp_svs>; >> + }; >> + >> + opp-300000000 { >> + opp-hz = /bits/ 64 <300000000>; >> + required-opps = <&rpmhpd_opp_nom>; >> + }; >> + }; >> + >> + qup_opp_table: opp-table-qup { >> + compatible = "operating-points-v2"; >> + >> + opp-75000000 { >> + opp-hz = /bits/ 64 <75000000>; >> + required-opps = <&rpmhpd_opp_low_svs>; >> + }; >> + >> + opp-100000000 { >> + opp-hz = /bits/ 64 <100000000>; >> + required-opps = <&rpmhpd_opp_svs>; >> + }; >> + >> + opp-128000000 { >> + opp-hz = /bits/ 64 <128000000>; >> + required-opps = <&rpmhpd_opp_nom>; >> + }; >> + }; >> + >> memory@...00000 { > Sidenote: memory@ should be moved above opp-*, alphabetically > > For this: > > Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org> You sure? Because before there is already opp for cpu... Best regards, Krzysztof
Powered by blists - more mailing lists