[<prev] [next>] [day] [month] [year] [list]
Message-Id: <20221211223553.59955-1-alexandre.belloni@bootlin.com>
Date: Sun, 11 Dec 2022 23:35:53 +0100
From: alexandre.belloni@...tlin.com
To: Alessandro Zummo <a.zummo@...ertech.it>,
Alexandre Belloni <alexandre.belloni@...tlin.com>,
Michael McCormick <michael.mccormick@...tel.net>
Cc: Janne Terho <janne.terho@...an.fi>, linux-rtc@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: [PATCH] rtc: pcf85063: fix pcf85063_clkout_control
From: Alexandre Belloni <alexandre.belloni@...tlin.com>
pcf85063_clkout_control reads the wrong register but then update the
correct one.
Reported-by: Janne Terho <janne.terho@...an.fi>
Fixes: 8c229ab6048b ("rtc: pcf85063: Add pcf85063 clkout control to common clock framework")
Signed-off-by: Alexandre Belloni <alexandre.belloni@...tlin.com>
---
drivers/rtc/rtc-pcf85063.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-pcf85063.c b/drivers/rtc/rtc-pcf85063.c
index 99f9cc57c7b3..754e03984f98 100644
--- a/drivers/rtc/rtc-pcf85063.c
+++ b/drivers/rtc/rtc-pcf85063.c
@@ -424,7 +424,7 @@ static int pcf85063_clkout_control(struct clk_hw *hw, bool enable)
unsigned int buf;
int ret;
- ret = regmap_read(pcf85063->regmap, PCF85063_REG_OFFSET, &buf);
+ ret = regmap_read(pcf85063->regmap, PCF85063_REG_CTRL2, &buf);
if (ret < 0)
return ret;
buf &= PCF85063_REG_CLKO_F_MASK;
--
2.38.1
Powered by blists - more mailing lists