lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 11 Dec 2022 22:42:26 +0000 From: Al Viro <viro@...iv.linux.org.uk> To: "Fabio M. De Francesco" <fmdefrancesco@...il.com> Cc: Evgeniy Dushistov <dushistov@...l.ru>, Ira Weiny <ira.weiny@...el.com>, linux-kernel@...r.kernel.org, bpf@...r.kernel.org, linux-fsdevel@...r.kernel.org Subject: Re: [PATCH 2/3] fs/ufs: Change the signature of ufs_get_page() On Sun, Dec 11, 2022 at 10:31:10PM +0100, Fabio M. De Francesco wrote: > out_put: > ufs_put_page(page); > -out: > - return err; > out_unlock: > unlock_page(page); > goto out_put; Something strange has happened, all right - look at the situation after that patch. You've got out_put: ufs_put_page(page); out_unlock: unlock_page(page); goto out_put; Which is obviously bogus.
Powered by blists - more mailing lists