linux-kernel - Re: fw_devlink=on breaks probing devices when of_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 11 Dec 2022 11:46:31 +0300
From:   Maksim Kiselev <bigunclemax@...il.com>
To:     olof@...om.net
Cc:     ansuelsmth@...il.com, devicetree@...r.kernel.org,
        gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        rafael@...nel.org, saravanak@...gle.com, zajec5@...il.com,
        fido_max@...ox.ru, =bigunclemax@...il.com
Subject: Re: fw_devlink=on breaks probing devices when of_platform_populate() is used

Hi, I have the same problem.
https://lore.kernel.org/all/CALHCpMgEZjnR39upkR6iozSk-b5A_GHRo9rcDSPXzzQi6x_qCw@mail.gmail.com/

I think the root of the problem was the choice of 'compatible'
device tree property to marking mtd partition node as a nvmem provider. 

This property used only inside 'mtd_nvmem_add' function to setup 
'no_of_node' flag.

> config.no_of_node = !of_device_is_compatible(node, "nvmem-cells");

This is how this flag processed by 'nvmem_register' function.

>	if (config->of_node)
>		nvmem->dev.of_node = config->of_node;
>	else if (!config->no_of_node)
>		nvmem->dev.of_node = config->dev->of_node;

Thats all, there is no such driver which compatible with 'nvmem-cells'.

So, maybe we should change the 'compatible' property to something else?