linux-kernel - drivers/net/ethernet/mediatek/mtk_wed_debugfs.c:73 dump_wed_regs() error: uninitialized symbol 'val'.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 12 Dec 2022 10:18:01 +0300
From:   Dan Carpenter <error27@...il.com>
To:     oe-kbuild@...ts.linux.dev, Felix Fietkau <nbd@....name>
Cc:     lkp@...el.com, oe-kbuild-all@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: drivers/net/ethernet/mediatek/mtk_wed_debugfs.c:73 dump_wed_regs()
 error: uninitialized symbol 'val'.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   3ecc37918c80ffdbfa8f08d3e75a0a9fca1c1979
commit: 804775dfc2885e93a0a4b35db1914c2cc25172b5 net: ethernet: mtk_eth_soc: add support for Wireless Ethernet Dispatch (WED)
config: openrisc-randconfig-m031-20221210
compiler: or1k-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Reported-by: Dan Carpenter <error27@...il.com>

smatch warnings:
drivers/net/ethernet/mediatek/mtk_wed_debugfs.c:73 dump_wed_regs() error: uninitialized symbol 'val'.

vim +/val +73 drivers/net/ethernet/mediatek/mtk_wed_debugfs.c

804775dfc2885e Felix Fietkau 2022-04-05  46  static void
804775dfc2885e Felix Fietkau 2022-04-05  47  dump_wed_regs(struct seq_file *s, struct mtk_wed_device *dev,
804775dfc2885e Felix Fietkau 2022-04-05  48  	      const struct reg_dump *regs, int n_regs)
804775dfc2885e Felix Fietkau 2022-04-05  49  {
804775dfc2885e Felix Fietkau 2022-04-05  50  	const struct reg_dump *cur;
804775dfc2885e Felix Fietkau 2022-04-05  51  	u32 val;
804775dfc2885e Felix Fietkau 2022-04-05  52  
804775dfc2885e Felix Fietkau 2022-04-05  53  	for (cur = regs; cur < &regs[n_regs]; cur++) {
804775dfc2885e Felix Fietkau 2022-04-05  54  		switch (cur->type) {
804775dfc2885e Felix Fietkau 2022-04-05  55  		case DUMP_TYPE_STRING:
804775dfc2885e Felix Fietkau 2022-04-05  56  			seq_printf(s, "%s======== %s:\n",
804775dfc2885e Felix Fietkau 2022-04-05  57  				   cur > regs ? "\n" : "",
804775dfc2885e Felix Fietkau 2022-04-05  58  				   cur->name);
804775dfc2885e Felix Fietkau 2022-04-05  59  			continue;
804775dfc2885e Felix Fietkau 2022-04-05  60  		case DUMP_TYPE_WED:
804775dfc2885e Felix Fietkau 2022-04-05  61  			val = wed_r32(dev, cur->offset);
804775dfc2885e Felix Fietkau 2022-04-05  62  			break;
804775dfc2885e Felix Fietkau 2022-04-05  63  		case DUMP_TYPE_WDMA:
804775dfc2885e Felix Fietkau 2022-04-05  64  			val = wdma_r32(dev, cur->offset);
804775dfc2885e Felix Fietkau 2022-04-05  65  			break;
804775dfc2885e Felix Fietkau 2022-04-05  66  		case DUMP_TYPE_WPDMA_TX:
804775dfc2885e Felix Fietkau 2022-04-05  67  			val = wpdma_tx_r32(dev, cur->base, cur->offset);
804775dfc2885e Felix Fietkau 2022-04-05  68  			break;
804775dfc2885e Felix Fietkau 2022-04-05  69  		case DUMP_TYPE_WPDMA_TXFREE:
804775dfc2885e Felix Fietkau 2022-04-05  70  			val = wpdma_txfree_r32(dev, cur->offset);
804775dfc2885e Felix Fietkau 2022-04-05  71  			break;

There are no DUMP_TYPE_WPDMA_RX and DUMP_TYPE_WED_RRO cases or a default
case.

804775dfc2885e Felix Fietkau 2022-04-05  72  		}
804775dfc2885e Felix Fietkau 2022-04-05 @73  		print_reg_val(s, cur->name, val);
804775dfc2885e Felix Fietkau 2022-04-05  74  	}
804775dfc2885e Felix Fietkau 2022-04-05  75  }

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp