[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 12 Dec 2022 09:07:19 +0100
From: Andrzej Pietrasiewicz <andrzej.p@...labora.com>
To: Alvin Šipraga <alvin@...s.dk>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Alvin Šipraga <alsi@...g-olufsen.dk>,
linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: gadget: u_ether: remove obnoxious warning messages
W dniu 9.12.2022 o 18:28, Alvin Šipraga pisze:
> From: Alvin Šipraga <alsi@...g-olufsen.dk>
>
> There is really no need for the driver to unconditionally emit warnings
> like this on every usage:
>
> [ 6.967283] using random self ethernet address
> [ 6.967294] using random host ethernet address
>
> Since this is normal behaviour, just remove the messages altogether.
> > Signed-off-by: Alvin Šipraga <alsi@...g-olufsen.dk>
Reviewed-by: Andrzej Pietrasiewicz <andrzej.p@...labora.com>
> ---
> drivers/usb/gadget/function/u_ether.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/usb/gadget/function/u_ether.c b/drivers/usb/gadget/function/u_ether.c
> index 8f12f3f8f6ee..3fdc913ef262 100644
> --- a/drivers/usb/gadget/function/u_ether.c
> +++ b/drivers/usb/gadget/function/u_ether.c
> @@ -845,13 +845,11 @@ struct net_device *gether_setup_name_default(const char *netname)
> snprintf(net->name, sizeof(net->name), "%s%%d", netname);
>
> eth_random_addr(dev->dev_mac);
> - pr_warn("using random %s ethernet address\n", "self");
>
> /* by default we always have a random MAC address */
> net->addr_assign_type = NET_ADDR_RANDOM;
>
> eth_random_addr(dev->host_mac);
> - pr_warn("using random %s ethernet address\n", "host");
>
> net->netdev_ops = ð_netdev_ops;
>
Powered by blists - more mailing lists