linux-kernel - Re: [PATCH 3/3] fs/ufs: Replace kmap() with kmap_local

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 12 Dec 2022 01:07:31 +0000
From:   Al Viro <viro@...iv.linux.org.uk>
To:     kernel test robot <lkp@...el.com>
Cc:     "Fabio M. De Francesco" <fmdefrancesco@...il.com>,
        Evgeniy Dushistov <dushistov@...l.ru>,
        Ira Weiny <ira.weiny@...el.com>, linux-kernel@...r.kernel.org,
        bpf@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev
Subject: Re: [PATCH 3/3] fs/ufs: Replace kmap() with kmap_local_page()

On Mon, Dec 12, 2022 at 08:52:47AM +0800, kernel test robot wrote:

> >> fs/ufs/dir.c:210:22: warning: variable 'kaddr' is uninitialized when used here [-Wuninitialized]
>            ufs_put_page(*page, kaddr);
>                                ^~~~~
>    fs/ufs/dir.c:196:13: note: initialize the variable 'kaddr' to silence this warning
>            char *kaddr;
>                       ^
>                        = NULL
>    1 warning generated.

Warning is right, suggestion - worse than useless...