linux-kernel - Re: [PATCH] slimbus: qcom-ngd: Add check for platform_driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 12 Dec 2022 10:26:11 +0000
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Jiasheng Jiang <jiasheng@...as.ac.cn>, agross@...nel.org,
        konrad.dybcio@...ainline.org
Cc:     linux-arm-msm@...r.kernel.org, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] slimbus: qcom-ngd: Add check for platform_driver_register



On 12/12/2022 09:49, Jiasheng Jiang wrote:
> Add the check for the return value of platform_driver_register
> in order to catch the exception.
> 
> Fixes: 917809e2280b ("slimbus: ngd: Add qcom SLIMBus NGD driver")
> Signed-off-by: Jiasheng Jiang <jiasheng@...as.ac.cn>

Applied thanks,

--srini
> ---
>   drivers/slimbus/qcom-ngd-ctrl.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctrl.c
> index 76c5e446d243..c16fc9e6d1c6 100644
> --- a/drivers/slimbus/qcom-ngd-ctrl.c
> +++ b/drivers/slimbus/qcom-ngd-ctrl.c
> @@ -1590,7 +1590,10 @@ static int qcom_slim_ngd_ctrl_probe(struct platform_device *pdev)
>   		goto err_pdr_lookup;
>   	}
>   
> -	platform_driver_register(&qcom_slim_ngd_driver);
> +	ret = platform_driver_register(&qcom_slim_ngd_driver);
> +	if (ret < 0)
> +		goto err_pdr_lookup; > +
>   	return of_qcom_slim_ngd_register(dev, ctrl);
>   
>   err_pdr_alloc: