linux-kernel - Re: [PATCH] nvmem: brcm_nvram: Add check for kzalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 12 Dec 2022 10:32:53 +0000
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Jiasheng Jiang <jiasheng@...as.ac.cn>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nvmem: brcm_nvram: Add check for kzalloc



On 12/12/2022 03:39, Jiasheng Jiang wrote:
> Add the check for the return value of kzalloc in order to avoid
> NULL pointer dereference.
> 
> Fixes: 6e977eaa8280 ("nvmem: brcm_nvram: parse NVRAM content into NVMEM cells")
> Signed-off-by: Jiasheng Jiang <jiasheng@...as.ac.cn>

Applied thanks,

--srini
> ---
>   drivers/nvmem/brcm_nvram.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/nvmem/brcm_nvram.c b/drivers/nvmem/brcm_nvram.c
> index 4441daa20965..7bd65fc2942e 100644
> --- a/drivers/nvmem/brcm_nvram.c
> +++ b/drivers/nvmem/brcm_nvram.c
> @@ -97,6 +97,9 @@ static int brcm_nvram_parse(struct brcm_nvram *priv)
>   	len = le32_to_cpu(header.len);
>   
>   	data = kzalloc(len, GFP_KERNEL);
> +	if (!data)
> +		return -ENOMEM;
> +
>   	memcpy_fromio(data, priv->base, len);
>   	data[len - 1] = '\0';
>