[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Sun, 11 Dec 2022 16:17:06 -1000
From: Tejun Heo <tj@...nel.org>
To: Julia Lawall <julia.lawall@...ia.fr>
Cc: torvalds@...ux-foundation.org, mingo@...hat.com,
peterz@...radead.org, juri.lelli@...hat.com,
vincent.guittot@...aro.org, dietmar.eggemann@....com,
rostedt@...dmis.org, bsegall@...gle.com, mgorman@...e.de,
bristot@...hat.com, vschneid@...hat.com, ast@...nel.org,
daniel@...earbox.net, andrii@...nel.org, martin.lau@...nel.org,
joshdon@...gle.com, brho@...gle.com, pjt@...gle.com,
derkling@...gle.com, haoluo@...gle.com, dvernet@...a.com,
dschatzberg@...a.com, dskarlat@...cmu.edu, riel@...riel.com,
linux-kernel@...r.kernel.org, bpf@...r.kernel.org,
kernel-team@...a.com
Subject: Re: [PATCH] sched_ext: use msecs_to_jiffies consistently
On Sun, Dec 11, 2022 at 11:43:30PM +0100, Julia Lawall wrote:
> The watchdog's timeout is processed by msecs_to_jiffies when it is
> checked, but not when the delay for running the watchdog is set. The
> watchdog will thus run at a time that is later than that time at which it
> is checked that it has run, and the scheduler aborts.
>
> Add the needed calls to msecs_to_jiffies.
>
> Signed-off-by: Julia Lawall <julia.lawall@...ia.fr>
>
> ---
>
> Another solution would be to use jiffies everywhere.
Yeah, that was how David Vernet implemented it in the first place and I
insisted on using non-jiffies unit, which clearly seems like a mistake. I
think the right thing to do here is using jiffies for everything.
Thanks.
--
tejun
Powered by blists - more mailing lists