[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 12 Dec 2022 16:48:26 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
Andy Gross <agross@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
CC: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 5/6] arm64: dts: qcom: sdm845: move sound node out of soc
On 12 December 2022 13:02:31 GMT+03:00, Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> wrote:
>The sound node is not property of the soc, but rather board as it
>describes the sound configuration. It also does not have unit address:
>
> sdm845-shift-axolotl.dtb: soc@0: sound: {} should not be valid under {'type': 'object'}
>
>Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>
Reviewed-by: Dmitry Baryshkov<dmitry.baryshkov@...aro.org>
>
>---
>
>Changes since v1:
>1. Add Rb tag.
>---
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
>index 8eeb3aa261d5..5f1f7cb52c90 100644
>--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
>+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
>@@ -3964,9 +3964,6 @@ lmh_cluster0: lmh@...78800 {
> #interrupt-cells = <1>;
> };
>
>- sound: sound {
>- };
>-
> usb_1_hsphy: phy@...2000 {
> compatible = "qcom,sdm845-qusb2-phy", "qcom,qusb2-v2-phy";
> reg = <0 0x088e2000 0 0x400>;
>@@ -5341,6 +5338,9 @@ wifi: wifi@...00000 {
> };
> };
>
>+ sound: sound {
>+ };
>+
> thermal-zones {
> cpu0-thermal {
> polling-delay-passive = <250>;
--
With best wishes
Dmitry
Powered by blists - more mailing lists