linux-kernel - Re: [PATCH v11 4/6] media: chips-media: wave5: Add TODO file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 12 Dec 2022 15:30:56 +0100
From:   Hans Verkuil <hverkuil-cisco@...all.nl>
To:     Sebastian Fricke <sebastian.fricke@...labora.com>,
        linux-media@...r.kernel.org, Nas Chung <nas.chung@...psnmedia.com>,
        Robert Beckett <bob.beckett@...labora.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>
Cc:     kernel@...labora.com, nicolas.dufresne@...labora.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v11 4/6] media: chips-media: wave5: Add TODO file

On 07/12/2022 13:13, Sebastian Fricke wrote:
> From: Nas Chung <nas.chung@...psnmedia.com>
> 
> Add a TODO file with remaining elements to be improved/added.
> 
> Signed-off-by: Robert Beckett <bob.beckett@...labora.com>
> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@...labora.com>
> Signed-off-by: Sebastian Fricke <sebastian.fricke@...labora.com>
> Signed-off-by: Nas Chung <nas.chung@...psnmedia.com>
> ---
>  drivers/media/platform/chips-media/wave5/TODO | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>  create mode 100644 drivers/media/platform/chips-media/wave5/TODO
> 
> diff --git a/drivers/media/platform/chips-media/wave5/TODO b/drivers/media/platform/chips-media/wave5/TODO
> new file mode 100644
> index 000000000000..2164fd071a56
> --- /dev/null
> +++ b/drivers/media/platform/chips-media/wave5/TODO
> @@ -0,0 +1,18 @@
> +* Handle interrupts better
> +
> +Currently the interrupt handling uses an unusual design employing a kfifo to
> +transfer irq status to irq thread. This was done as a work around for dropped
> +interrupts seen with IRQF_ONESHOT based handling.
> +
> +This needs further investigation and fixing properly, with the aid of
> +C&M.
> +
> +* power management handling - add (runtime_)suspen/resume cb where the clock is enabled
> +
> +* revise logic of wave5_vpu_(dec/enc)_register_framebuffer
> +
> +* check if the  normal kernel endianness/__swab32 routines are sufficient. (instead of the ones
> +  implemented in the driver)
> +
> +* Adjust STREAMON routine for the stateful decoder to adhere to the API, which
> +  declares that STREAMON can be called before source buffers have been queued.

A TODO file doesn't belong in a non-staging driver.

So either it should remain in staging if this is serious enough (and I'm a bit
worried about the last item here!), or it should be documented in comments in
the driver in the appropriate places.

Note that the "revise logic" item doesn't explain the reason why that should be
done.

Regards,

	Hans