linux-kernel - Re: [PATCH] dmaengine: idxd: Remove the unused function set_completion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 12 Dec 2022 08:32:43 -0700
From:   Dave Jiang <dave.jiang@...el.com>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        fenghua.yu@...el.com
Cc:     vkoul@...nel.org, dmaengine@...r.kernel.org,
        linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] dmaengine: idxd: Remove the unused function
 set_completion_address()



On 12/11/2022 8:35 PM, Jiapeng Chong wrote:
> The function set_completion_address is defined in the dma.c file, but not
> called elsewhere, so remove this unused function.
> 
> drivers/dma/idxd/dma.c:66:20: warning: unused function 'set_completion_address'.
> 
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3416
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>

Acked-by: Dave Jiang <dave.jiang@...el.com>
Thanks for the cleanup
> ---
>   drivers/dma/idxd/dma.c | 6 ------
>   1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/dma/idxd/dma.c b/drivers/dma/idxd/dma.c
> index e0874cb4721c..eb35ca313684 100644
> --- a/drivers/dma/idxd/dma.c
> +++ b/drivers/dma/idxd/dma.c
> @@ -63,12 +63,6 @@ static void op_flag_setup(unsigned long flags, u32 *desc_flags)
>   		*desc_flags |= IDXD_OP_FLAG_RCI;
>   }
>   
> -static inline void set_completion_address(struct idxd_desc *desc,
> -					  u64 *compl_addr)
> -{
> -		*compl_addr = desc->compl_dma;
> -}
> -
>   static inline void idxd_prep_desc_common(struct idxd_wq *wq,
>   					 struct dsa_hw_desc *hw, char opcode,
>   					 u64 addr_f1, u64 addr_f2, u64 len,