linux-kernel - Re: [PATCH] perf tools: Fix a typo in BTF tracepoint name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 12 Dec 2022 12:42:39 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Namhyung Kim <namhyung@...nel.org>
Cc:     Jiri Olsa <jolsa@...nel.org>, Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Ian Rogers <irogers@...gle.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        linux-perf-users@...r.kernel.org, Song Liu <song@...nel.org>,
        bpf@...r.kernel.org
Subject: Re: [PATCH] perf tools: Fix a typo in BTF tracepoint name

Em Thu, Dec 08, 2022 at 10:26:36AM -0800, Namhyung Kim escreveu:
> In the BTF, tracepoint definitions have the prefix of "btf_trace_".
> The off-cpu profilier needs to check the signature of sched_switch
> event using the definition.  But there's a typo (s/bpf/btf/) so it
> failed always.

Thanks, applied.

- Arnaldo

 
> Fixes: b36888f71c85 ("perf record: Handle argument change in sched_switch")
> Signed-off-by: Namhyung Kim <namhyung@...nel.org>
> ---
>  tools/perf/util/bpf_off_cpu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/bpf_off_cpu.c b/tools/perf/util/bpf_off_cpu.c
> index c257813e674e..01f70b8e705a 100644
> --- a/tools/perf/util/bpf_off_cpu.c
> +++ b/tools/perf/util/bpf_off_cpu.c
> @@ -102,7 +102,7 @@ static void check_sched_switch_args(void)
>  	const struct btf_type *t1, *t2, *t3;
>  	u32 type_id;
>  
> -	type_id = btf__find_by_name_kind(btf, "bpf_trace_sched_switch",
> +	type_id = btf__find_by_name_kind(btf, "btf_trace_sched_switch",
>  					 BTF_KIND_TYPEDEF);
>  	if ((s32)type_id < 0)
>  		return;
> -- 
> 2.39.0.rc1.256.g54fd8350bd-goog

-- 

- Arnaldo