[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 12 Dec 2022 10:17:35 -0800
From: Josh Don <joshdon@...gle.com>
To: Chen Yu <yu.c.chen@...el.com>
Cc: Yicong Yang <yangyicong@...wei.com>, yangyicong@...ilicon.com,
Vincent Guittot <vincent.guittot@...aro.org>,
Joel Fernandes <joel@...lfernandes.org>,
Honglei Wang <wanghonglei@...ichuxing.com>,
Peter Zijlstra <peterz@...radead.org>,
Tim Chen <tim.c.chen@...el.com>,
Mel Gorman <mgorman@...hsingularity.net>,
Juri Lelli <juri.lelli@...hat.com>,
Rik van Riel <riel@...riel.com>,
Aaron Lu <aaron.lu@...el.com>,
Abel Wu <wuyun.abel@...edance.com>,
K Prateek Nayak <kprateek.nayak@....com>,
"Gautham R . Shenoy" <gautham.shenoy@....com>,
Ingo Molnar <mingo@...hat.com>,
Dietmar Eggemann <dietmar.eggemann@....com>,
Steven Rostedt <rostedt@...dmis.org>,
Ben Segall <bsegall@...gle.com>,
Daniel Bristot de Oliveira <bristot@...hat.com>,
Valentin Schneider <vschneid@...hat.com>,
Hillf Danton <hdanton@...a.com>,
Len Brown <len.brown@...el.com>,
Chen Yu <yu.chen.surf@...il.com>,
Tianchen Ding <dtcccc@...ux.alibaba.com>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] sched/fair: Introduce short duration task check
> BTW, I've changed the threshold to (sysctl_sched_min_granularity / 8) in my next
> version, as this is the value that fit my previous test case and also not to break
> the case Josh mentioned.
Do you mean a hardcoded value of some number of micros, or literally
sched_min_granularity / 8? I don't think the latter is necessary, and
indeed can lead to weirdness if min_gran is too small or too large. I
don't think the concept of what a short duration task is should
expand/contract with min_gran.
Best,
Josh
Powered by blists - more mailing lists