linux-kernel - Re: [PATCH] arch: change variable types to match those of what is assigned to them

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <33fd0ddb-c2dc-c403-a742-bac32d24825c@infradead.org>
Date:   Tue, 13 Dec 2022 09:40:44 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     "Seija K." <doremylover123@...il.com>,
        Stefano Stabellini <sstabellini@...nel.org>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Chris Zankel <chris@...kel.net>,
        Max Filippov <jcmvbkbc@...il.com>
Cc:     linux-kernel@...r.kernel.org, xen-devel@...ts.xenproject.org,
        linux-arm-kernel@...ts.infradead.org, linux-mips@...r.kernel.org
Subject: Re: [PATCH] arch: change variable types to match those of what is
 assigned to them

Hi,

Please look at
  https://lore.kernel.org/lkml/CAA42iKx2f2LsAQ9C5rxnCTPhOB6n+L35Winc5WK1K2EySAjvXA@mail.gmail.com/T/#u

and see if that matches what you thought you sent as a patch.

The gmail web interface is notorious for dropping tabs in emails.


On 12/13/22 09:35, Seija K. wrote:
> There are many places where "int len = strlen(foo);" is written, just
> for len to be passed as a parameter of size_t. This causes truncation
> and then expansion back from int to size_t. Not to mention this is
> poor logic and needless truncations can add extra unneeded
> instructions.
> 
> This patch aims to fix the worst offenders.
> 
> Signed-off-by: Seija Kijin <doremylover123@...il.com>
> ---
>  arch/arm/mm/mmu.c                      | 30 +++++++++++++-------------
>  arch/arm/probes/kprobes/test-core.c    |  8 +++----
>  arch/arm/vfp/vfpmodule.c               |  4 ++--
>  arch/arm/xen/p2m.c                     |  4 ++--
>  arch/mips/alchemy/common/irq.c         |  2 +-
>  arch/mips/alchemy/common/prom.c        |  2 +-
>  arch/mips/alchemy/devboards/bcsr.c     |  2 +-
>  arch/mips/alchemy/devboards/platform.c |  8 +++----
>  arch/mips/ar7/prom.c                   |  4 ++--
>  arch/mips/boot/compressed/dbg.c        | 14 +++++-------
>  arch/mips/fw/arc/cmdline.c             |  4 ++--
>  arch/xtensa/platforms/iss/console.c    |  4 ++--
>  12 files changed, 41 insertions(+), 45 deletions(-)
> 


-- 
~Randy