linux-kernel - Re: [PATCH] kselftest/alsa: Increase kselftest timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 13 Dec 2022 11:37:56 -0700
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Nícolas F. R. A. Prado 
        <nfraprado@...labora.com>, Mark Brown <broonie@...nel.org>
Cc:     kernel@...labora.com, Jaroslav Kysela <perex@...ex.cz>,
        Shuah Khan <shuah@...nel.org>, Takashi Iwai <tiwai@...e.com>,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
        linux-kselftest@...r.kernel.org,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] kselftest/alsa: Increase kselftest timeout

On 12/13/22 11:32, Nícolas F. R. A. Prado wrote:
> The default timeout for kselftests is 45 seconds, but pcm-test can take
> longer than that to run depending on the number of PCMs present on a
> device.
> 
> As a data point, running pcm-test on mt8192-asurada-spherion takes about
> 1m15s.
> 
> Set the timeout to 10 minutes, which should give enough slack to run the
> test even on devices with many PCMs.
> 

10 minutes is way too long.

> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@...labora.com>
> 
> ---
> 
>   tools/testing/selftests/alsa/settings | 1 +
>   1 file changed, 1 insertion(+)
>   create mode 100644 tools/testing/selftests/alsa/settings
> 
> diff --git a/tools/testing/selftests/alsa/settings b/tools/testing/selftests/alsa/settings
> new file mode 100644
> index 000000000000..a62d2fa1275c
> --- /dev/null
> +++ b/tools/testing/selftests/alsa/settings
> @@ -0,0 +1 @@
> +timeout=600

Adding timeouts like this especially 10 minutes will increase the time
it takes to run tests. We run the risk of people not wanting to run tests
anymore.

thanks,
-- Shuah