linux-kernel - Re: [PATCH -next 8/8] mm: damon: remove unneed damon_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20221213192633.138774-1-sj@kernel.org>
Date:   Tue, 13 Dec 2022 19:26:33 +0000
From:   SeongJae Park <sj@...nel.org>
To:     Kefeng Wang <wangkefeng.wang@...wei.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        David Hildenbrand <david@...hat.com>,
        Oscar Salvador <osalvador@...e.de>,
        SeongJae Park <sj@...nel.org>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, damon@...ts.linux.dev,
        vishal.moola@...il.com, willy@...radead.org
Subject: Re: [PATCH -next 8/8] mm: damon: remove unneed damon_get_page()

Hi Kefeng,

On Tue, 13 Dec 2022 17:27:35 +0800 Kefeng Wang <wangkefeng.wang@...wei.com> wrote:

> After all damon_get_page() callers are converted to damon_get_folio(),
> remove unneed wrapper damon_get_page().
> 
> Signed-off-by: Kefeng Wang <wangkefeng.wang@...wei.com>
> ---
>  mm/damon/ops-common.h | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/mm/damon/ops-common.h b/mm/damon/ops-common.h
> index 4ee607813981..35a2e42a27da 100644
> --- a/mm/damon/ops-common.h
> +++ b/mm/damon/ops-common.h
> @@ -8,13 +8,6 @@
>  #include <linux/damon.h>
>  
>  struct folio *damon_get_folio(unsigned long pfn);
> -static inline struct page *damon_get_page(unsigned long pfn)
> -{
> -	struct folio *folio = damon_get_folio(pfn);
> -
> -	return &folio->page;
> -}
> -
>  void damon_ptep_mkold(pte_t *pte, struct mm_struct *mm, unsigned long addr);

Let's keep the one blank line before damon_ptep_mkold().

>  void damon_pmdp_mkold(pmd_t *pmd, struct mm_struct *mm, unsigned long addr);
>  
> -- 
> 2.35.3

Thanks,
SJ