linux-kernel - Re: [RFC][PATCH] trace: Add trace points for tasklet entry/exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221213154347.118e6444@gandalf.local.home>
Date:   Tue, 13 Dec 2022 15:43:47 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     John Stultz <jstultz@...gle.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Lingutla Chandrasekhar <clingutla@...eaurora.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        "Paul E. McKenney" <paulmck@...nel.org>,
        "Connor O'Brien" <connoro@...gle.com>, kernel-team@...roid.com,
        "J . Avila" <elavila@...gle.com>
Subject: Re: [RFC][PATCH] trace: Add trace points for tasklet entry/exit

On Tue, 13 Dec 2022 18:53:10 +0000
John Stultz <jstultz@...gle.com> wrote:

> From: Lingutla Chandrasekhar <clingutla@...eaurora.org>
> 
> Tasklets are supposed to finish their work quickly and
> should not block the current running process, but it is not
> guaranteed that. Currently softirq_entry/exit can be used to
> know total tasklets execution time, but not helpful to track
> individual tasklet's execution time. With that we can't find
> any culprit tasklet function, which is taking more time.
> 
> Add tasklet_entry/exit trace point support to track
> individual tasklet execution.
> 
> This patch has been carried in the Android tree for awhile
> so I wanted to submit it for review upstream. Feedback would
> be appreciated!
> 
> Cc: Steven Rostedt <rostedt@...dmis.org>
> Cc: Masami Hiramatsu <mhiramat@...nel.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: "Paul E. McKenney" <paulmck@...nel.org>
> Cc: Connor O'Brien <connoro@...gle.com>
> Cc: kernel-team@...roid.com
> Signed-off-by: Lingutla Chandrasekhar <clingutla@...eaurora.org>
> [elavila: Port to android-mainline]
> Signed-off-by: J. Avila <elavila@...gle.com>
> [jstultz: Rebased to upstream, cut unused trace points, added
>  comments for the tracepoints, reworded commit]
> Signed-off-by: John Stultz <jstultz@...gle.com>
> ---

This looks fine to me.

Reviewed-by: Steven Rostedt (Google) <rostedt@...dmis.org>

-- Steve