linux-kernel - Re: [PATCH net-next] net: microchip: vcap: Fix initialization of value and mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221213073545.vuel5l6k7cej6xk6@soft-dev3-1>
Date:   Tue, 13 Dec 2022 08:35:45 +0100
From:   Horatiu Vultur <horatiu.vultur@...rochip.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     <linux-arm-kernel@...ts.infradead.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <davem@...emloft.net>,
        <edumazet@...gle.com>, <pabeni@...hat.com>,
        <Steen.Hegelund@...rochip.com>, <daniel.machon@...rochip.com>,
        <lars.povlsen@...rochip.com>, <UNGLinuxDriver@...rochip.com>,
        kernel test robot <lkp@...el.com>,
        "Dan Carpenter" <error27@...il.com>
Subject: Re: [PATCH net-next] net: microchip: vcap: Fix initialization of
 value and mask

The 12/12/2022 13:02, Jakub Kicinski wrote:
> 
> On Fri, 9 Dec 2022 13:07:01 +0100 Horatiu Vultur wrote:
> >       case VCAP_FIELD_U128:
> > +             value = data->u128.value;
> > +             mask = data->u128.value;
> 
> If setting both to value is intentional - please mention in the commit
> message. Otherwise this looks odd.

It should not be both set to value. Will fix this in th next version.

-- 
/Horatiu