linux-kernel - Re: [PATCH v4] arm64: dts: qcom: sa8540p-ride: enable pcie2a node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 13 Dec 2022 09:10:41 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Shazad Hussain <quic_shazhuss@...cinc.com>, andersson@...nel.org,
        johan@...nel.org
Cc:     bmasney@...hat.com, kernel test robot <lkp@...el.com>,
        Andy Gross <agross@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] arm64: dts: qcom: sa8540p-ride: enable pcie2a node

On 13/12/2022 09:05, Shazad Hussain wrote:
> 
> 
> On 12/13/2022 1:31 PM, Krzysztof Kozlowski wrote:
>> On 13/12/2022 06:11, Shazad Hussain wrote:
>>> Add the pcie2a, pcie2a_phy, and respective tlmm
>>> nodes that are needed to get pcie 2a controller
>>> enabled on Qdrive3.
>>>
>>> This patch enables 4GB 64bit memory space for
>>> PCIE_2A to have BAR allocations of 64bit pref mem
>>> needed on this Qdrive3 platform with dual SoCs
>>> for root port and switch NT-EP. Hence this ranges
>>> property is overridden in sa8540p-ride.dts only.
>>>
>>> Signed-off-by: Shazad Hussain <quic_shazhuss@...cinc.com>
>>> Reviewed-by: Brian Masney <bmasney@...hat.com>
>>> Reported-by: kernel test robot <lkp@...el.com>
>>
>> Drop, robot did not report this patch.
>>
> 
> You mean I should keep only Kernel test as Reported by ?

No, I mean entire line should be removed. This robot did not report
missing feature/bug thus there is no credit for him for creating this patch.

> 
>>> ---
>>> Changes since v3:
>>> - Fix syntax error and add Reported-by (Kernel test robot)
>>
>> So the previous patch was not even build... thus 100% not tested. Is
>> this one at least built?
>>
> 
> I built that, but after running checkpatch with --fix, I think it 
> dropped the closing brace of tlmm. My bad :|

Please do not send patches with checkpatch --fix, without prior testing
the patch. Not the code, but the patch. By testing patch I mean checking
different mainline branch, applying the mbox/patch (git am) and
comparing with git diff.

Best regards,
Krzysztof