linux-kernel - Re: [PATCH] nvme-pci: fix doorbell buffer value endianness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y5g9QhH1asYdXpZx@cormorant.local>
Date:   Tue, 13 Dec 2022 09:52:18 +0100
From:   Klaus Jensen <its@...elevant.dk>
To:     Christoph Hellwig <hch@....de>
Cc:     linux-nvme@...ts.infradead.org, Keith Busch <kbusch@...nel.org>,
        Jens Axboe <axboe@...com>, Sagi Grimberg <sagi@...mberg.me>,
        linux-kernel@...r.kernel.org, Klaus Jensen <k.jensen@...sung.com>,
        Guenter Roeck <linux@...ck-us.net>
Subject: Re: [PATCH] nvme-pci: fix doorbell buffer value endianness

On Dec 13 09:50, Christoph Hellwig wrote:
> On Mon, Dec 12, 2022 at 04:02:43PM +0100, Klaus Jensen wrote:
> > -		old_value = *dbbuf_db;
> > -		*dbbuf_db = value;
> > +		old_value = le32_to_cpu(*dbbuf_db);
> > +		*dbbuf_db = cpu_to_le32(value);
> 
> As the buildbot noticed, this now means dbbuf_dbs needs to be
> a __le32, and the endianess annoations will have to wee through
> quite a few places.
> 

Yes, I'll fix it :)

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)