linux-kernel - Re: [PATCH v6 11/14] kernel: events: Export perf_report_aux_output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9ea2a0d8-b025-bb56-3a04-1a88e340da2d@arm.com>
Date:   Tue, 13 Dec 2022 10:08:08 +0000
From:   Suzuki K Poulose <suzuki.poulose@....com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     mathieu.poirier@...aro.org, mingo@...hat.com, acme@...nel.org,
        linux-perf-users@...r.kernel.org, leo.yan@...aro.org,
        quic_jinlmao@...cinc.com, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, coresight@...ts.linaro.org,
        Mike Leach <mike.leach@...aro.org>
Subject: Re: [PATCH v6 11/14] kernel: events: Export
 perf_report_aux_output_id()

Peter,

On 24/11/2022 11:04, Suzuki Kuruppassery Poulose wrote:
> Peter
> 
> 
> On 23/11/2022 19:50, Mike Leach wrote:
>> CoreSight trace being updated to use the perf_report_aux_output_id()
>> in a similar way to intel-pt.
>>
>> This function in needs export visibility to allow it to be called from
>> kernel loadable modules, which CoreSight may configured to be built as.
>>
>> Signed-off-by: Mike Leach <mike.leach@...aro.org>
>> Acked-by: Suzuki K Poulose <suzuki.poulose@....com>
>> ---
>>   kernel/events/core.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/kernel/events/core.c b/kernel/events/core.c
>> index 4ec3717003d5..ad388552f1d5 100644
>> --- a/kernel/events/core.c
>> +++ b/kernel/events/core.c
>> @@ -9231,6 +9231,7 @@ void perf_report_aux_output_id(struct perf_event 
>> *event, u64 hw_id)
>>       perf_output_end(&handle);
>>   }
>> +EXPORT_SYMBOL_GPL(perf_report_aux_output_id);
> 
> Are you happy with me picking up this change through the coresight  tree ?
> 
> Suzuki
> 

Please could you let me know your thoughts on this ? Coresight PMU would
use this to inform the dynamically allocated trace id for a CPU to the
perf via this HWID packet.

If you are happy with the above change, I could pick it up via the
coresight tree with your Ack. Otherwise, please could you pick it
up ?

Suzuki